From 0e5a02bb72c7fea3e3b206ae5a291ca542ca8c10 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 23 Feb 2015 12:32:33 +0100 Subject: [PATCH] [PASSED QA] Bug 13731: Suggestions reason does not save on updating the status MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. Works as expected. Signed-off-by: Marc VĂ©ron Signed-off-by: Katrin Fischer Works as expected, thx! --- suggestion/suggestion.pl | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index b54703a..3d10111 100755 --- a/suggestion/suggestion.pl +++ b/suggestion/suggestion.pl @@ -176,14 +176,11 @@ elsif ($op eq "change" ) { } if ( my $reason = $$suggestion_ref{"reason$tabcode"}){ if ( $reason eq "other" ) { - $reason = $$suggestion_ref{"other_reason$tabcode"}; + $reason = $$suggestion_ref{"other_reason$tabcode"}; } - $$suggestion_ref{'reason'}=$reason; - } - delete $$suggestion_ref{$_} foreach ("reason$tabcode", "other_reason$tabcode"); - foreach (keys %$suggestion_ref){ - delete $$suggestion_ref{$_} unless ($$suggestion_ref{$_}); + $suggestion_only->{reason}=$reason; } + foreach my $suggestionid (@editsuggestions) { next unless $suggestionid; $suggestion_only->{'suggestionid'}=$suggestionid; -- 1.9.1