Bugzilla – Attachment 38570 Details for
Bug 12109
Authority subfield configuration page for controlled fields is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12109: Fix tab on the auth subfield configuration page
Bug-12109-Fix-tab-on-the-auth-subfield-configurati.patch (text/plain), 1.85 KB, created by
Jonathan Druart
on 2015-04-27 15:25:06 UTC
(
hide
)
Description:
Bug 12109: Fix tab on the auth subfield configuration page
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-04-27 15:25:06 UTC
Size:
1.85 KB
patch
obsolete
>From 1f302082afbe9492b27e84ef102b51abaefeb135 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 27 Apr 2015 17:16:32 +0200 >Subject: [PATCH] Bug 12109: Fix tab on the auth subfield configuration page > >There is a condition in the template to not display the "New" tab if the >user is editing a control field. >But it results in a broken template. >Looking at the biblio frameworks, the New tab exists even for control >fields. > >This patch only fixes the html structure, but a complete fix should be >provide, for auth and biblio, if we want not to let the ability to >create subfields for control fields. > >Test plan: >Edit subfields for a control field >(admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance) >and confirm that the view is now fixed. >--- > .../intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >index f7b1d52..87b468b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >@@ -62,9 +62,7 @@ function displayMoreConstraint(numlayer){ > <ul> > [% FOREACH loo IN loop %] > [% IF ( loo.new_subfield ) %] >- [% IF ( tagfield >=10 ) %]<!-- display new only for > 10 fields --> > <li><a href="#sub[% loo.tagsubfield %]field" title="[% loo.liblibrarian %]">New</a></li> >- [% END %] > [% ELSE %] > <li><a href="#sub[% loo.tagsubfield %]field" title="[% loo.liblibrarian %]"> > [% loo.tagsubfield %] >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12109
:
38570
|
38635
|
38701