Bugzilla – Attachment 38971 Details for
Bug 13758
KOHAVERSION should be statically set
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13758: Correct KOHA::VERSION in OverDrive.pm
Bug-13758-Correct-KOHAVERSION-in-OverDrivepm.patch (text/plain), 1.36 KB, created by
Marcel de Rooy
on 2015-05-08 08:20:59 UTC
(
hide
)
Description:
Bug 13758: Correct KOHA::VERSION in OverDrive.pm
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2015-05-08 08:20:59 UTC
Size:
1.36 KB
patch
obsolete
>From 38e382fcb682e45d0680951e334e962e2190f7e9 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 8 May 2015 10:08:02 +0200 >Subject: [PATCH] Bug 13758: Correct KOHA::VERSION in OverDrive.pm >Content-Type: text/plain; charset=utf-8 > >Correct $KOHA::VERSION to $Koha::VERSION. >Also, passing this string to LWP::UserAgent is wrong. It expects key/value >pairs. Since this string is apparently intended as an agent, this patch >passes it as such. >Note: The OverDrive has unfortunately no unit tests. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Tested this change in the perl debugger with just these lines: > use C4::External::OverDrive; > C4::External::OverDrive::_request(); >Printed $ua->agent while stepping into sub _request. >Without the agent change, the adjusted Koha string would just be ignored >and I would still have "libwww-perl/6.04" as agent. >--- > C4/External/OverDrive.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/External/OverDrive.pm b/C4/External/OverDrive.pm >index 338dd76..369377a 100644 >--- a/C4/External/OverDrive.pm >+++ b/C4/External/OverDrive.pm >@@ -40,7 +40,7 @@ BEGIN { > > sub _request { > my ( $request ) = @_; >- my $ua = LWP::UserAgent->new( "Koha " . $KOHA::VERSION ); >+ my $ua = LWP::UserAgent->new( agent => "Koha " . $Koha::VERSION ); > > my $response; > eval { >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13758
:
36951
|
36962
|
36963
|
36988
|
38661
|
38662
|
38663
|
38738
|
38739
|
38952
|
38958
| 38971