From d8bea501376f1b299bbeaeafd4dc74dfb8e74a58 Mon Sep 17 00:00:00 2001 From: Aleisha Date: Tue, 12 May 2015 03:01:35 +0000 Subject: [PATCH] Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl This patch sets $limit to be an empty string. Test plan ========= 1/ login into the opac using your user account credentials 2/ in a terminal, run a `tail -f ` on your instance's opac-error.log 3/ go back to the opac, click on 'your reading history' tab to go to opac-readingrecord.pl 4/ notice the warning - "opac-readingrecord.pl: Use of uninitialized value $limit" appear in the `tail`ed opac-error.log 5/ apply the patch 6/ reload the page (opac-readingrecord.pl) 7/ page works but the warning in step #4 is no longer logged 8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error Remarks: Testing result match expected test plan output. The QA tests pass with "OK" for the commit. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) --- opac/opac-readingrecord.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/opac/opac-readingrecord.pl b/opac/opac-readingrecord.pl index 4a1ac78..795e90c 100755 --- a/opac/opac-readingrecord.pl +++ b/opac/opac-readingrecord.pl @@ -73,6 +73,7 @@ else { my $limit = $query->param('limit'); +$limit //= ''; $limit = ( $limit eq 'full' ) ? 0 : 50; my $issues = GetAllIssues( $borrowernumber, $order, $limit ); -- 1.9.1