From a883bc457aefae5592fbc10338d6e5683561d94b Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 01:50:33 +1200 Subject: [PATCH] [PASSED QA] Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Reports/Guided.pm - Subroutine prototypes used at line 376, column 1. See page 194 of PBP. (Severity: 5) - Bareword file handle opened at line 757, column 2. See pages 202,204 of PBP. (Severity: 5) - Two-argument "open" used at line 757, column 2. See page 207 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall --- C4/Reports/Guided.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm index 97a41c7..6c5a477 100644 --- a/C4/Reports/Guided.pm +++ b/C4/Reports/Guided.pm @@ -880,7 +880,7 @@ sub _get_column_defs { my ($theme, $lang, $availablethemes) = C4::Templates::themelanguage($htdocs, 'about.tt', $section, $cgi); my $full_path_to_columns_def_file="$htdocs/$theme/$lang/$columns_def_file"; - open (my $fh, $full_path_to_columns_def_file); + open (my $fh, '<', $full_path_to_columns_def_file); while ( my $input = <$fh> ){ chomp $input; if ( $input =~ m|(.*)| ) { -- 1.7.2.5