Bugzilla – Attachment 39792 Details for
Bug 7232
clicking title on receive should open in new window/tab
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7232: Opens title and suggestion in new tab so as to not lose the basket
Bug-7232-Opens-title-and-suggestion-in-new-tab-so-.patch (text/plain), 4.01 KB, created by
Aleisha Amohia
on 2015-06-03 05:13:30 UTC
(
hide
)
Description:
Bug 7232: Opens title and suggestion in new tab so as to not lose the basket
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2015-06-03 05:13:30 UTC
Size:
4.01 KB
patch
obsolete
>From f812def07b79b6cada794d86992ed4289180883b Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Wed, 3 Jun 2015 02:38:40 +0000 >Subject: [PATCH] Bug 7232: Opens title and suggestion in new tab so as to not > lose the basket > >Have added target="_blank" to the title link in parcel.tt as well as the title link and suggestion link in basket.tt so that when the user goes to these links, they will not lose the basket page. > >To test: >1) Go to Acquisitions, find a vendor and add some orders to the basket, one from an existing record and one from a suggestion. >2) VIEW the basket (basket.pl) >3) Click on a title, click on the link to a suggestion. Notice these open in new tabs >4) Close the basket >5) Click 'Receive shipment' (will be taken to parcel.pl) >6) Click on a title, click on the link to a suggestion. Notice these open in new tabs >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 22d6631..a3d6418 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -461,7 +461,7 @@ > <td> > <p> > [% IF ( books_loo.order_received ) %] (rcvd)[% END %] >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% books_loo.biblionumber %]">[% books_loo.title |html %]</a> by [% books_loo.author %] >+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% books_loo.biblionumber %]" target="_blank" >[% books_loo.title |html %]</a> by [% books_loo.author %] > <br /> > [% IF ( books_loo.isbn ) %] - [% books_loo.isbn %][% END %] > [% IF ( books_loo.issn ) %] - [% books_loo.issn %][% END %] >@@ -471,7 +471,7 @@ > [% IF ( books_loo.suggestionid ) %] > <br/> > Suggested by: [% books_loo.surnamesuggestedby %][% IF ( books_loo.firstnamesuggestedby ) %], [% books_loo.firstnamesuggestedby %] [% END %] >- (<a href="/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=[% books_loo.suggestionid %]&op=show">suggestion #[% books_loo.suggestionid %]</a>) >+ (<a href="/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=[% books_loo.suggestionid %]&op=show" target="_blank" >suggestion #[% books_loo.suggestionid %]</a>) > [% END %] > </p> > [% IF ( books_loo.order_internalnote ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index a244f5f..aef4804 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -253,7 +253,7 @@ > </td> > <td class="orderfilterclass"><a href="neworderempty.pl?ordernumber=[% loop_order.ordernumber %]&booksellerid=[% loop_order.booksellerid %]">[% loop_order.ordernumber %]</a></td> > <td class="summaryfilterclass"> >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% loop_order.biblionumber %]">[% loop_order.title |html %]</a> >+ <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% loop_order.biblionumber %]" target="_blank" >[% loop_order.title |html %]</a> > [% IF ( loop_order.author ) %] by [% loop_order.author %][% END %] > [% IF ( loop_order.isbn ) %] – [% loop_order.isbn %][% END %] > [% IF ( loop_order.publishercode ) %]<br />Publisher:[% loop_order.publishercode %][% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7232
: 39792 |
39793