Bugzilla – Attachment 40495 Details for
Bug 14423
Multiple XSS and XSRF issues in Staff Client
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14423 : XSS in authorities-home
PASSED-QA-Bug-14423--XSS-in-authorities-home.patch (text/plain), 2.41 KB, created by
Katrin Fischer
on 2015-06-22 21:04:24 UTC
(
hide
)
Description:
[PASSED QA] Bug 14423 : XSS in authorities-home
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-06-22 21:04:24 UTC
Size:
2.41 KB
patch
obsolete
>From 66f78805774af81eb85d82f2001f4b1d454cc5a3 Mon Sep 17 00:00:00 2001 >From: Chris <chris@bigballofwax.co.nz> >Date: Sun, 21 Jun 2015 08:10:20 +0000 >Subject: [PATCH] [PASSED QA] Bug 14423 : XSS in authorities-home > >To test: >1/ Hit a url like http://localhost:8081/cgi-bin/koha/authorities/authorities-home.pl?op=do_search&type=intranet&marclist=mainentry&and_or=and&operator=contains&value=%22/%3E%3Cscript%3Ealert%28%27oh%20noes%27%29%3C/script%3E >2/ Notice you get 3 alert boxes >3/ Apply patch >4/ Hit the url again, no js > >Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc >index cbdc939..433c927 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc >@@ -58,7 +58,7 @@ > <option value="is">is exactly</option> > [% END %] > </select> >- <input id="value_mainentry" type="text" name="value" value="[% value %]" /> >+ <input id="value_mainentry" type="text" name="value" value="[% value | html%]" /> > <select name="orderby"> > [% IF ( orderby == 'HeadingAsc' ) %] > <option value="HeadingAsc" selected="selected">Heading A-Z</option> >@@ -112,7 +112,7 @@ > <option value="is">is exactly</option> > [% END %] > </select> >- <input id="value_matchheading" type="text" name="value" value="[% value %]" /> >+ <input id="value_matchheading" type="text" name="value" value="[% value | html %]" /> > <select name="orderby"> > [% IF ( orderby == 'HeadingAsc' ) %] > <option value="HeadingAsc" selected="selected">Heading A-Z</option> >@@ -168,7 +168,7 @@ > <option value="is">is exactly</option> > [% END %] > </select> >- <input id="value_anywhere" type="text" name="value" value="[% value %]" /> >+ <input id="value_anywhere" type="text" name="value" value="[% value | html %]" /> > <select name="orderby"> > [% IF ( orderby == 'HeadingAsc' ) %] > <option value="HeadingAsc" selected="selected">Heading A-Z</option> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14423
:
40383
|
40435
|
40436
|
40437
|
40438
|
40439
|
40440
|
40441
|
40449
|
40450
|
40451
|
40452
|
40453
|
40454
|
40455
| 40495 |
40496
|
40497
|
40498
|
40499
|
40500
|
40501
|
40503