View | Details | Raw Unified | Return to bug 12375
Collapse All | Expand All

(-)a/C4/Serials.pm (-23 / +15 lines)
Lines 1529-1564 sub NewIssue { Link Here
1529
        }
1529
        }
1530
    );
1530
    );
1531
1531
1532
    my $dbh   = C4::Context->dbh;
1533
    my $serialid = $serial->serialid();
1532
    my $serialid = $serial->serialid();
1534
1533
1535
    my $query = qq|
1534
    my $subscription_history = $schema->resultset('Subscriptionhistory')->find($subscriptionid);
1536
        SELECT missinglist,recievedlist
1535
    my $missinglist = $subscription_history->missinglist();
1537
        FROM   subscriptionhistory
1536
    my $recievedlist = $subscription_history->recievedlist();
1538
        WHERE  subscriptionid=?
1539
    |;
1540
    my $sth = $dbh->prepare($query);
1541
    $sth->execute($subscriptionid);
1542
    my ( $missinglist, $recievedlist ) = $sth->fetchrow;
1543
1537
1544
    if ( $status == ARRIVED ) {
1538
    if ( $status == ARRIVED ) {
1545
      ### TODO Add a feature that improves recognition and description.
1539
        ### TODO Add a feature that improves recognition and description.
1546
      ### As such count (serialseq) i.e. : N18,2(N19),N20
1540
        ### As such count (serialseq) i.e. : N18,2(N19),N20
1547
      ### Would use substr and index But be careful to previous presence of ()
1541
        ### Would use substr and index But be careful to previous presence of ()
1548
        $recievedlist .= "; $serialseq" unless (index($recievedlist,$serialseq)>0);
1542
        $recievedlist .= "; $serialseq" unless ( index( $recievedlist, $serialseq ) > 0 );
1549
    }
1543
    }
1550
    if ( grep {/^$status$/} ( MISSING_STATUSES ) ) {
1544
    if ( grep { /^$status$/ } (MISSING_STATUSES) ) {
1551
        $missinglist .= "; $serialseq" unless (index($missinglist,$serialseq)>0);
1545
        $missinglist .= "; $serialseq" unless ( index( $missinglist, $serialseq ) > 0 );
1552
    }
1546
    }
1553
    $query = qq|
1547
1554
        UPDATE subscriptionhistory
1555
        SET    recievedlist=?, missinglist=?
1556
        WHERE  subscriptionid=?
1557
    |;
1558
    $sth = $dbh->prepare($query);
1559
    $recievedlist =~ s/^; //;
1548
    $recievedlist =~ s/^; //;
1560
    $missinglist  =~ s/^; //;
1549
    $missinglist  =~ s/^; //;
1561
    $sth->execute( $recievedlist, $missinglist, $subscriptionid );
1550
1551
    $subscription_history->recievedlist($recievedlist);
1552
    $subscription_history->missinglist($missinglist);
1553
    $subscription_history->update();
1554
1562
    return $serialid;
1555
    return $serialid;
1563
}
1556
}
1564
1557
1565
- 

Return to bug 12375