From ef9a0f11d8575c4c5cf14364af63f329839d4e1a Mon Sep 17 00:00:00 2001 From: Amit Gupta Date: Mon, 29 Jun 2015 21:42:08 +0530 Subject: [PATCH 2/2] Bug 14472 - Wrong ISSN search index in record matching rules To Test --------- 1) Apply the patch 2) Export some MARC bibliographic records from Koha 3) Import those same MARC bibliographic records using the "ISSN(022$a)" record matching rule. 4) The incoming records should match perfectly 5) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. For new Koha installation 1) create the koha database 2) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 3) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. --- .../optional/marc21_default_matching_rules.sql | 2 +- .../optional/marc21_default_matching_rules.sql | 2 +- .../optional/marc21_default_matching_rules.sql | 2 +- .../Optionnel/marc21_default_matching_rules.sql | 2 +- .../optional/marc21_default_matching_rules.sql | 2 +- .../optional/marc21_default_matching_rules.sql | 2 +- .../optional/marc21_default_matching_rules.sql | 2 +- .../optional/marc21_default_matching_rules.sql | 2 +- .../optional/marc21_default_matching_rules.sql | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_default_matching_rules.sql b/installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_default_matching_rules.sql index 4d39a5e..b863911 100644 --- a/installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_default_matching_rules.sql +++ b/installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_default_matching_rules.sql @@ -29,7 +29,7 @@ INSERT INTO matchpoint_component_norms (matchpoint_component_id, sequence, norm_ INSERT INTO marc_matchers (code, description, record_type, threshold) VALUES ('ISSN', '022$a', 'biblio', 1000); -INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'isbn', 1000 FROM marc_matchers; +INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'issn', 1000 FROM marc_matchers; INSERT INTO matcher_matchpoints SELECT MAX(matcher_id), MAX(matchpoint_id) FROM matchpoints; INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields) SELECT MAX(matchpoint_id), 1, '022', 'a' FROM matchpoints; diff --git a/installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.sql b/installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.sql index 801f04a..2e538a4 100644 --- a/installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.sql +++ b/installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.sql @@ -29,7 +29,7 @@ INSERT INTO matchpoint_component_norms (matchpoint_component_id, sequence, norm_ INSERT INTO marc_matchers (code, description, record_type, threshold) VALUES ('ISSN', '022$a', 'biblio', 1000); -INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'isbn', 1000 FROM marc_matchers; +INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'issn', 1000 FROM marc_matchers; INSERT INTO matcher_matchpoints SELECT MAX(matcher_id), MAX(matchpoint_id) FROM matchpoints; INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields) SELECT MAX(matchpoint_id), 1, '022', 'a' FROM matchpoints; diff --git a/installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_default_matching_rules.sql b/installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_default_matching_rules.sql index 4d39a5e..b863911 100644 --- a/installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_default_matching_rules.sql +++ b/installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_default_matching_rules.sql @@ -29,7 +29,7 @@ INSERT INTO matchpoint_component_norms (matchpoint_component_id, sequence, norm_ INSERT INTO marc_matchers (code, description, record_type, threshold) VALUES ('ISSN', '022$a', 'biblio', 1000); -INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'isbn', 1000 FROM marc_matchers; +INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'issn', 1000 FROM marc_matchers; INSERT INTO matcher_matchpoints SELECT MAX(matcher_id), MAX(matchpoint_id) FROM matchpoints; INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields) SELECT MAX(matchpoint_id), 1, '022', 'a' FROM matchpoints; diff --git a/installer/data/mysql/fr-FR/marcflavour/marc21/Optionnel/marc21_default_matching_rules.sql b/installer/data/mysql/fr-FR/marcflavour/marc21/Optionnel/marc21_default_matching_rules.sql index 4d39a5e..b863911 100644 --- a/installer/data/mysql/fr-FR/marcflavour/marc21/Optionnel/marc21_default_matching_rules.sql +++ b/installer/data/mysql/fr-FR/marcflavour/marc21/Optionnel/marc21_default_matching_rules.sql @@ -29,7 +29,7 @@ INSERT INTO matchpoint_component_norms (matchpoint_component_id, sequence, norm_ INSERT INTO marc_matchers (code, description, record_type, threshold) VALUES ('ISSN', '022$a', 'biblio', 1000); -INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'isbn', 1000 FROM marc_matchers; +INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'issn', 1000 FROM marc_matchers; INSERT INTO matcher_matchpoints SELECT MAX(matcher_id), MAX(matchpoint_id) FROM matchpoints; INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields) SELECT MAX(matchpoint_id), 1, '022', 'a' FROM matchpoints; diff --git a/installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_default_matching_rules.sql b/installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_default_matching_rules.sql index 4d39a5e..b863911 100644 --- a/installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_default_matching_rules.sql +++ b/installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_default_matching_rules.sql @@ -29,7 +29,7 @@ INSERT INTO matchpoint_component_norms (matchpoint_component_id, sequence, norm_ INSERT INTO marc_matchers (code, description, record_type, threshold) VALUES ('ISSN', '022$a', 'biblio', 1000); -INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'isbn', 1000 FROM marc_matchers; +INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'issn', 1000 FROM marc_matchers; INSERT INTO matcher_matchpoints SELECT MAX(matcher_id), MAX(matchpoint_id) FROM matchpoints; INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields) SELECT MAX(matchpoint_id), 1, '022', 'a' FROM matchpoints; diff --git a/installer/data/mysql/nb-NO/marcflavour/marc21/optional/marc21_default_matching_rules.sql b/installer/data/mysql/nb-NO/marcflavour/marc21/optional/marc21_default_matching_rules.sql index 4d39a5e..b863911 100644 --- a/installer/data/mysql/nb-NO/marcflavour/marc21/optional/marc21_default_matching_rules.sql +++ b/installer/data/mysql/nb-NO/marcflavour/marc21/optional/marc21_default_matching_rules.sql @@ -29,7 +29,7 @@ INSERT INTO matchpoint_component_norms (matchpoint_component_id, sequence, norm_ INSERT INTO marc_matchers (code, description, record_type, threshold) VALUES ('ISSN', '022$a', 'biblio', 1000); -INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'isbn', 1000 FROM marc_matchers; +INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'issn', 1000 FROM marc_matchers; INSERT INTO matcher_matchpoints SELECT MAX(matcher_id), MAX(matchpoint_id) FROM matchpoints; INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields) SELECT MAX(matchpoint_id), 1, '022', 'a' FROM matchpoints; diff --git a/installer/data/mysql/pl-PL/marcflavour/marc21/optional/marc21_default_matching_rules.sql b/installer/data/mysql/pl-PL/marcflavour/marc21/optional/marc21_default_matching_rules.sql index 266a300..083efdf 100644 --- a/installer/data/mysql/pl-PL/marcflavour/marc21/optional/marc21_default_matching_rules.sql +++ b/installer/data/mysql/pl-PL/marcflavour/marc21/optional/marc21_default_matching_rules.sql @@ -29,7 +29,7 @@ INSERT INTO matchpoint_component_norms (matchpoint_component_id, sequence, norm_ INSERT INTO marc_matchers (code, description, record_type, threshold) VALUES ('ISSN', '022$a', 'biblio', 1000); -INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'isbn', 1000 FROM marc_matchers; +INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'issn', 1000 FROM marc_matchers; INSERT INTO matcher_matchpoints SELECT MAX(matcher_id), MAX(matchpoint_id) FROM matchpoints; INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields) SELECT MAX(matchpoint_id), 1, '022', 'a' FROM matchpoints; diff --git a/installer/data/mysql/ru-RU/marcflavour/marc21/optional/marc21_default_matching_rules.sql b/installer/data/mysql/ru-RU/marcflavour/marc21/optional/marc21_default_matching_rules.sql index 4f41421..5415075 100644 --- a/installer/data/mysql/ru-RU/marcflavour/marc21/optional/marc21_default_matching_rules.sql +++ b/installer/data/mysql/ru-RU/marcflavour/marc21/optional/marc21_default_matching_rules.sql @@ -29,7 +29,7 @@ INSERT INTO matchpoint_component_norms (matchpoint_component_id, sequence, norm_ INSERT INTO marc_matchers (code, description, record_type, threshold) VALUES ('ISSN', '022$a', 'biblio', 1000); -INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'isbn', 1000 FROM marc_matchers; +INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'issn', 1000 FROM marc_matchers; INSERT INTO matcher_matchpoints SELECT MAX(matcher_id), MAX(matchpoint_id) FROM matchpoints; INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields) SELECT MAX(matchpoint_id), 1, '022', 'a' FROM matchpoints; diff --git a/installer/data/mysql/uk-UA/marcflavour/marc21/optional/marc21_default_matching_rules.sql b/installer/data/mysql/uk-UA/marcflavour/marc21/optional/marc21_default_matching_rules.sql index 4f41421..5415075 100644 --- a/installer/data/mysql/uk-UA/marcflavour/marc21/optional/marc21_default_matching_rules.sql +++ b/installer/data/mysql/uk-UA/marcflavour/marc21/optional/marc21_default_matching_rules.sql @@ -29,7 +29,7 @@ INSERT INTO matchpoint_component_norms (matchpoint_component_id, sequence, norm_ INSERT INTO marc_matchers (code, description, record_type, threshold) VALUES ('ISSN', '022$a', 'biblio', 1000); -INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'isbn', 1000 FROM marc_matchers; +INSERT INTO matchpoints (matcher_id, search_index, score) SELECT MAX(matcher_id), 'issn', 1000 FROM marc_matchers; INSERT INTO matcher_matchpoints SELECT MAX(matcher_id), MAX(matchpoint_id) FROM matchpoints; INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields) SELECT MAX(matchpoint_id), 1, '022', 'a' FROM matchpoints; -- 1.7.9.5