From f361187892333c2abd8b0aac60af09019f9b62fc Mon Sep 17 00:00:00 2001 From: Aleisha Date: Wed, 1 Jul 2015 02:31:19 +0000 Subject: [PATCH] Bug 14480: Silences warns triggered when modifying patron These warns are triggered when editing a patron: memberentry.pl: Argument "" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/members/memberentry.pl line 566 memberentry.pl: Argument "" isn't numeric in numeric lt (<) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt line 949 To test: 1) Go to any patron (ie this link http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1369) 2) Click Edit 3) Notice the above warns 4) Apply patch and reload page 5) Notice warns are gone but page still works correctly --- koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- members/memberentry.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index 330058f..072ba71 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -916,7 +916,7 @@
Patron restrictions - [% IF ( debarments.size < 1 ) %] + [% IF ( debarments.size && debarments.size < 1 ) %]

Patron is currently unrestricted.

[% ELSE %] diff --git a/members/memberentry.pl b/members/memberentry.pl index 967ebd1..eac8300 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -563,7 +563,7 @@ if (@{$city_arrayref} ) { if ($default_city) { # flag the current or default val for my $city ( @{$city_arrayref} ) { - if ($default_city == $city->{cityid}) { + if ($default_city eq $city->{cityid}) { $city->{selected} = 1; last; } -- 1.7.10.4