From d89aa33970ddd1a1ac99cef2ad2ef8d97117a755 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 27 Aug 2015 10:01:53 +0200 Subject: [PATCH] Bug 14306: Remove call to GetMarcNotes from sendshelf Content-Type: text/plain; charset=utf-8 Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). --- opac/opac-sendshelf.pl | 2 -- virtualshelves/sendshelf.pl | 2 -- 2 files changed, 4 deletions(-) diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl index 8512c65..e3fe4f1 100755 --- a/opac/opac-sendshelf.pl +++ b/opac/opac-sendshelf.pl @@ -84,7 +84,6 @@ if ( $email ) { my $fw = GetFrameworkCode($biblionumber); my $dat = GetBiblioData($biblionumber); my $record = GetMarcBiblio($biblionumber, 1); - my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); my $subtitle = GetRecordValue('subtitle', $record, $fw); @@ -92,7 +91,6 @@ if ( $email ) { my @items = GetItemsInfo( $biblionumber ); $dat->{ISBN} = GetMarcISBN($record, $marcflavour); - $dat->{MARCNOTES} = $marcnotesarray; $dat->{MARCSUBJCTS} = $marcsubjctsarray; $dat->{MARCAUTHORS} = $marcauthorsarray; $dat->{'biblionumber'} = $biblionumber; diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl index 2fa77b2..d9d7f4c 100755 --- a/virtualshelves/sendshelf.pl +++ b/virtualshelves/sendshelf.pl @@ -82,14 +82,12 @@ if ($email) { my $fw = GetFrameworkCode($biblionumber); my $dat = GetBiblioData($biblionumber); my $record = GetMarcBiblio($biblionumber, 1); - my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); my $subtitle = GetRecordValue( 'subtitle', $record, $fw ); my @items = GetItemsInfo($biblionumber); - $dat->{MARCNOTES} = $marcnotesarray; $dat->{MARCSUBJCTS} = $marcsubjctsarray; $dat->{MARCAUTHORS} = $marcauthorsarray; $dat->{'biblionumber'} = $biblionumber; -- 1.7.10.4