Bugzilla – Attachment 42180 Details for
Bug 14685
Cannot set guarantor for a child account
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 14685: Fix set guarantor for a child or professional accounts
PASSED-QA-Bug-14685-Fix-set-guarantor-for-a-child-.patch (text/plain), 1.70 KB, created by
Katrin Fischer
on 2015-09-01 21:30:05 UTC
(
hide
)
Description:
[PASSED QA] Bug 14685: Fix set guarantor for a child or professional accounts
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2015-09-01 21:30:05 UTC
Size:
1.70 KB
patch
obsolete
>From 70d0a756a6b35e3f31ea33af2d71818deb14b00c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 Aug 2015 09:08:09 +0100 >Subject: [PATCH] [PASSED QA] Bug 14685: Fix set guarantor for a child or > professional accounts > >Bug 13970 removed some useful code to automatically set the guarantor >when creating a child. > >But finally there is a better way to do the job, we just need to assume >that only children or professional can have a guarantor. > >Test plan: >1/ Create an adult patron and add a child. >2/ The guarantor info should be retrieved and set on the child creation >page. >3/ Create an organization and add a child >4/ The guarantor info should be retrieved and set on the adult creation >page. > >Signed-off-by: Liz Rea <liz@catalyst.net.nz> >This patch catches both cases, thanks Jonathan! > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > members/memberentry.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 7904e55..225e03b 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -238,8 +238,9 @@ if ( ( $op eq 'insert' ) and !$nodouble ) { > } > > #recover all data from guarantor address phone ,fax... >-if ( $guarantorid and ( $category_type eq 'C' || $category_type eq 'P' )) { >+if ( $guarantorid ) { > if (my $guarantordata=GetMember(borrowernumber => $guarantorid)) { >+ $category_type = $guarantordata->{categorycode} eq 'I' ? 'P' : 'C'; > $guarantorinfo=$guarantordata->{'surname'}." , ".$guarantordata->{'firstname'}; > $newdata{'contactfirstname'}= $guarantordata->{'firstname'}; > $newdata{'contactname'} = $guarantordata->{'surname'}; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14685
:
41552
|
41570
|
41577
|
41640
| 42180