Bugzilla – Attachment 42417 Details for
Bug 14744
Cannot select guarantor when quote in one of the fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
CAM 2145 - Bug 14744 - Fix window closing when selecting a guarantor
CAM-2145---Bug-14744---Fix-window-closing-when-sel.patch (text/plain), 2.22 KB, created by
Genevieve Plantin
on 2015-09-04 20:53:51 UTC
(
hide
)
Description:
CAM 2145 - Bug 14744 - Fix window closing when selecting a guarantor
Filename:
MIME Type:
Creator:
Genevieve Plantin
Created:
2015-09-04 20:53:51 UTC
Size:
2.22 KB
patch
obsolete
>From a6cbdcfc6752b8ff0ce887bd8b3d5b09228b3e71 Mon Sep 17 00:00:00 2001 >From: genevieve <genevieve.plantin@inlibro.com> >Date: Fri, 4 Sep 2015 16:51:16 -0400 >Subject: [PATCH] CAM 2145 - Bug 14744 - Fix window closing when selecting a > guarantor > >After slecting a guarantor, the window was not closing. > >Some parts of the form in the user_select function are not defined yet, so the JavaScript was crashing when it encounters the undefined form fields preventing it from closing the window. I only had if conditions to prevent the script form bugging and to close the window. >--- > .../prog/en/modules/members/memberentrygen.tt | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 905eda6..1fbd5fc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -120,14 +120,14 @@ > .val(borrower.firstname) > .before('<span>' + borrower.firstname + '</span>').get(0).type = 'hidden'; > >- form.streetnumber.value = borrower.streetnumber; >- form.address.value = borrower.address; >- form.address2.value = borrower.address2; >- form.city.value = borrower.city; >- form.state.value = borrower.state; >- form.zipcode.value = borrower.zipcode; >- form.country.value = borrower.country; >- form.branchcode.value = borrower.branchcode; >+ if (form.streetnumber != undefined) form.streetnumber.value = borrower.streetnumber; >+ if (form.address != undefined) form.address.value = borrower.address; >+ if (form.address2 != undefined) form.address2.value = borrower.address2; >+ if (form.city != undefined) form.city.value = borrower.city; >+ if (form.state != undefined) form.state.value = borrower.state; >+ if (form.zipcode != undefined) form.zipcode.value = borrower.zipcode; >+ if (form.country != undefined) form.country.value = borrower.country; >+ if (form.branchcode != undefined) form.branchcode.value = borrower.branchcode; > > form.guarantorsearch.value = _("Change"); > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14744
:
42416
| 42417 |
42419