Bugzilla – Attachment 42833 Details for
Bug 14883
Librarians are not warned if patron is restricted when placing holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 14883 - Librarians are not warned if patron is restricted when placing holds
Signed-off-Bug-14883---Librarians-are-not-warned-i.patch (text/plain), 2.76 KB, created by
Marc Véron
on 2015-09-24 06:50:43 UTC
(
hide
)
Description:
[Signed-off] Bug 14883 - Librarians are not warned if patron is restricted when placing holds
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2015-09-24 06:50:43 UTC
Size:
2.76 KB
patch
obsolete
>From b15fd19b0655fc0093775501a23e991450eb4a05 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 23 Sep 2015 10:44:20 -0400 >Subject: [PATCH] [Signed-off] Bug 14883 - Librarians are not warned if patron > is restricted when placing holds >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Librarians should be warned that a patron is restricted when placing >holds, as they are warned that a patron's acount has expired. > >Test Plan: >1) Apply this patch >2) Add a restriction for a patron >3) Attempt to place a hold for that patron >4) Note the notice at the top notifying you that the patron is restricted > >Works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++++ > reserve/request.pl | 2 ++ > 2 files changed, 6 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 1a62e91..f6f52cc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -333,6 +333,10 @@ function checkMultiHold() { > <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a>'s <strong>account has expired</strong></li> > [% END %] > >+ [% IF restricted %] >+ <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]#reldebarments">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>has restrictions</strong></li> >+ [% END %] >+ > [% IF amount_outstanding && Koha.Preference('maxoutstanding') && amount_outstanding > Koha.Preference('maxoutstanding') %] > <li><a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>owes [% amount_outstanding | format('%.2f') %]</strong></li> > [% END %] >diff --git a/reserve/request.pl b/reserve/request.pl >index 8ddbb84..fbd5fb6 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -44,6 +44,7 @@ use C4::Utils::DataTables::Members; > use C4::Members; > use C4::Search; # enabled_staff_search_views > use Koha::DateUtils; >+use Koha::Borrower::Debarments qw(IsDebarred); > > my $dbh = C4::Context->dbh; > my $sth; >@@ -176,6 +177,7 @@ if ($borrowernumber_hold && !$action) { > diffbranch => $diffbranch, > messages => $messages, > warnings => $warnings, >+ restricted => IsDebarred($borrowerinfo->{'borrowernumber'}), > amount_outstanding => GetMemberAccountRecords($borrowerinfo->{borrowernumber}), > ); > } >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14883
:
42814
|
42833
|
42839