Bugzilla – Attachment 43294 Details for
Bug 14515
Add biblioitems table to notices in C4/Reserves.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14515: Add biblioitems to messages in C4/Reserves.pm
Bug-14515-Add-biblioitems-to-messages-in-C4Reserve.patch (text/plain), 3.71 KB, created by
Jonathan Druart
on 2015-10-09 11:03:31 UTC
(
hide
)
Description:
Bug 14515: Add biblioitems to messages in C4/Reserves.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-10-09 11:03:31 UTC
Size:
3.71 KB
patch
obsolete
>From 1f4e0c6c244a2b64ad2e9d9f7f094398381815db Mon Sep 17 00:00:00 2001 >From: Barton Chittenden <barton@bywatersolutions.com> >Date: Thu, 9 Jul 2015 13:23:49 -0700 >Subject: [PATCH] Bug 14515: Add biblioitems to messages in C4/Reserves.pm > >http://bugs.koha-community.org/show_bug.cgi?id=14515 > >Signed-off-by: Danielle Aloia <daloia@nyam.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Reserves.pm | 60 +++++++++++++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 51 insertions(+), 9 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 4b10ff9..3d293b3 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -150,6 +150,16 @@ BEGIN { > > AddReserve($branch,$borrowernumber,$biblionumber,$bibitems,$priority,$resdate,$expdate,$notes,$title,$checkitem,$found) > >+Adds reserve and generates HOLDPLACED message. >+ >+The following tables are available witin the HOLDPLACED message: >+ >+ branches >+ borrowers >+ biblio >+ biblioitems >+ items >+ > =cut > > sub AddReserve { >@@ -220,10 +230,11 @@ sub AddReserve { > letter_code => 'HOLDPLACED', > branchcode => $branch, > tables => { >- 'branches' => $branch_details, >- 'borrowers' => $borrower, >- 'biblio' => $biblionumber, >- 'items' => $checkitem, >+ 'branches' => $branch_details, >+ 'borrowers' => $borrower, >+ 'biblio' => $biblionumber, >+ 'biblioitems' => $biblionumber, >+ 'items' => $checkitem, > }, > ) ) { > >@@ -1938,6 +1949,25 @@ sub _Findgroupreserve { > Sends a notification to the patron that their hold has been filled (through > ModReserveAffect, _not_ ModReserveFill) > >+The letter code for this notice may be found using the following query: >+ >+ select distinct letter_code >+ from message_transports >+ inner join message_attributes using (message_attribute_id) >+ where message_name = 'Hold_Filled' >+ >+This will probably sipmly be 'HOLD', but because it is defined in the database, >+it is subject to addition or change. >+ >+The following tables are availalbe witin the notice: >+ >+ branches >+ borrowers >+ biblio >+ biblioitems >+ reserves >+ items >+ > =cut > > sub _koha_notify_reserve { >@@ -1970,10 +2000,11 @@ sub _koha_notify_reserve { > module => 'reserves', > branchcode => $reserve->{branchcode}, > tables => { >- 'branches' => $branch_details, >- 'borrowers' => $borrower, >- 'biblio' => $biblionumber, >- 'reserves' => $reserve, >+ 'branches' => $branch_details, >+ 'borrowers' => $borrower, >+ 'biblio' => $biblionumber, >+ 'biblioitems' => $biblionumber, >+ 'reserves' => $reserve, > 'items', $reserve->{'itemnumber'}, > }, > substitute => { today => C4::Dates->new()->output() }, >@@ -2307,7 +2338,17 @@ sub GetReserveId { > > ReserveSlip($branchcode, $borrowernumber, $biblionumber) > >- Returns letter hash ( see C4::Letters::GetPreparedLetter ) or undef >+Returns letter hash ( see C4::Letters::GetPreparedLetter ) or undef >+ >+The letter code will be RESERVESLIP, and the following tables are >+available within the slip: >+ >+ reserves >+ branches >+ borrowers >+ biblio >+ biblioitems >+ items > > =cut > >@@ -2331,6 +2372,7 @@ sub ReserveSlip { > 'branches' => $reserve->{branchcode}, > 'borrowers' => $reserve->{borrowernumber}, > 'biblio' => $reserve->{biblionumber}, >+ 'biblioitems' => $reserve->{biblionumber}, > 'items' => $reserve->{itemnumber}, > }, > ); >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14515
:
40902
|
42979
|
43179
|
43180
|
43294
|
43295
|
46026
|
46027