Bugzilla – Attachment 43319 Details for
Bug 14999
Adding to basket orders from staged files mixes up the prices between different orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14999: Fetch the corresponding values for the specific biblio item
Bug-14999-Fetch-the-corresponding-values-for-the-s.patch (text/plain), 3.39 KB, created by
Joonas Kylmälä
on 2015-10-10 12:44:14 UTC
(
hide
)
Description:
Bug 14999: Fetch the corresponding values for the specific biblio item
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2015-10-10 12:44:14 UTC
Size:
3.39 KB
patch
obsolete
>From 94ab153e20cd4549ecd459e84dc79e18c9b43196 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <j.kylmala@gmail.com> >Date: Sat, 10 Oct 2015 12:39:32 +0000 >Subject: [PATCH] Bug 14999: Fetch the corresponding values for the specific > biblio item > >Sponsored-by: Vaara-kirjastot >--- > acqui/addorderiso2709.pl | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > >diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl >index 5a26e71..3406cdf 100755 >--- a/acqui/addorderiso2709.pl >+++ b/acqui/addorderiso2709.pl >@@ -168,22 +168,31 @@ if ($op eq ""){ > for my $biblio (@$biblios){ > # Check if this import_record_id was selected > next if not grep { $_ eq $$biblio{import_record_id} } @import_record_id_selected; >+ >+ # With this we know from which index from the http params we get the data >+ my $index; >+ for (my $i = 0; $i <= $#import_record_id_selected; $i++) { >+ if ($import_record_id_selected[$i] eq $$biblio{import_record_id}) { >+ $index = $i; >+ last; >+ } >+ } > my ( $marcblob, $encoding ) = GetImportRecordMarc( $biblio->{'import_record_id'} ); > my $marcrecord = MARC::Record->new_from_usmarc($marcblob) || die "couldn't translate marc information"; > my $match = GetImportRecordMatches( $biblio->{'import_record_id'}, 1 ); > my $biblionumber=$#$match > -1?$match->[0]->{'biblionumber'}:0; >- my $c_overlay = shift @overlay; >- my $c_quantity = shift( @quantities ) || GetMarcQuantity($marcrecord, C4::Context->preference('marcflavour') ) || 1; >- my $c_budget_id = shift( @budgets_id ) || $input->param('all_budget_id') || $budget_id; >- my $c_discount = shift ( @discount); >+ my $c_overlay = $overlay[$index]; >+ my $c_quantity = $quantities[$index] || GetMarcQuantity($marcrecord, C4::Context->preference('marcflavour') ) || 1; >+ my $c_budget_id = $budgets_id[$index] || $input->param('all_budget_id') || $budget_id; >+ my $c_discount = $discount[$index]; > if ($c_discount) { > $c_discount =~ s/%//g; #This screws up number conversion badly > $c_discount =~ s/,/./g; #Make this an actual digit for Perl > $c_discount = $c_discount / 100 if $c_discount >= 1; > } > $c_discount = $c_discount / 100 if $c_discount && $c_discount > 1; >- my $c_sort1 = shift( @sort1 ) || $input->param('all_sort1') || ''; >- my $c_sort2 = shift( @sort2 ) || $input->param('all_sort2') || ''; >+ my $c_sort1 = $sort1[$index] || $input->param('all_sort1') || ''; >+ my $c_sort2 = $sort2[$index] || $input->param('all_sort2') || ''; > > # INSERT the biblio if no match found, or if we want to overlay the existing match > if ( not($biblionumber) || $c_overlay ) { >@@ -235,7 +244,7 @@ if ($op eq ""){ > currency => $cgiparams->{'all_currency'}, > ); > # get the price if there is one. >- my $price= shift( @prices ) || GetMarcPrice($marcrecord, C4::Context->preference('marcflavour')); >+ my $price = $prices[$index] || GetMarcPrice($marcrecord, C4::Context->preference('marcflavour')); > if ($price){ > # in France, the cents separator is the , but sometimes, ppl use a . > # in this case, the price will be x100 when unformatted ! Replace the . by a , to get a proper price calculation >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14999
:
43319
|
43363
|
43364
|
125648
|
125689
|
127176