Bugzilla – Attachment 4504 Details for
Bug 6518
XSS vulnerabilities in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6518 : Fixing XSS issues on opac
Bug-6518--Fixing-XSS-issues-on-opac.patch (text/plain), 5.71 KB, created by
Chris Cormack
on 2011-06-19 10:05:45 UTC
(
hide
)
Description:
Bug 6518 : Fixing XSS issues on opac
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2011-06-19 10:05:45 UTC
Size:
5.71 KB
patch
obsolete
>From 31bdb45727aa6e0841027f705e9453603386f647 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Fri, 17 Jun 2011 08:39:29 +1200 >Subject: [PATCH] Bug 6518 : Fixing XSS issues on opac > >--- > .../prog/en/modules/opac-addbybiblionumber.tt | 2 +- > .../opac-tmpl/prog/en/modules/opac-downloadcart.tt | 2 +- > .../prog/en/modules/opac-downloadshelf.tt | 2 +- > koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt | 6 +++--- > .../prog/en/modules/opac-serial-issues.tt | 4 ++-- > 5 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt >index dab4fda..f6479f9 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt >@@ -66,7 +66,7 @@ > <option value="1">Private</option> > <option value="2">Public</option> > </select></li></ol></fieldset> >- [% FOREACH biblio IN biblios %] <input type="hidden" name="biblionumber" value="[% biblio.biblionumber %]" />[% END %] >+ [% FOREACH biblio IN biblios %] <input type="hidden" name="biblionumber" value="[% biblio.biblionumber | html%]" />[% END %] > <fieldset class="action"><input type="submit" value="Save" class="submit" /> <a class="close cancel" href="#">Cancel</a></fieldset> > </form> > [% END %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadcart.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadcart.tt >index 45d5de7..8d22c4d 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadcart.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadcart.tt >@@ -19,7 +19,7 @@ > </select></li></ol> > </fieldset> > <fieldset class="action"> >- <input type="hidden" name="bib_list" value="[% bib_list %]" /> >+ <input type="hidden" name="bib_list" value="[% bib_list | html %]" /> > <input type="submit" name="save" value="Go" /> > </fieldset> > </form> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadshelf.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadshelf.tt >index 608c955..b984f5d 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadshelf.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-downloadshelf.tt >@@ -26,7 +26,7 @@ > > </select></li></ol> > </fieldset> >- <fieldset class="action"> <input type="hidden" name="shelfid" value="[% shelfid %]" /> >+ <fieldset class="action"> <input type="hidden" name="shelfid" value="[% shelfid | html %]" /> > <input type="submit" name="save" value="Go" /></fieldset> > </form> > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt >index 338f174..3e69614 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt >@@ -11,7 +11,7 @@ > [% IF ( cgi_debug ) %]alert(_('injecting OLD comment: ')+comment);[% END %] > parent.opener.$('#c[% reviewid %] p').prev("small").prev("h5").html("Your Edited Comment (preview, pending approval)"); > parent.opener.$('#c[% reviewid %] p').html(comment); >- parent.opener.$('#c[% reviewid %] p').append(" <a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=[% biblionumber %]&reviewid=[% reviewid %]\');\">Edit<\/a>"); >+ parent.opener.$('#c[% reviewid %] p').append("<a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=[% biblionumber | uri %]&reviewid=[% reviewid | uri%]\');\">Edit<\/a>"); > [% END %] > return 1; > }; >@@ -21,7 +21,7 @@ > parent.opener.$('#newcomment').html( > "<h5>Your Comment (preview, pending approval)<\/h5>" + > "<p>"+comment+"<\/p>" + >- "<a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=[% biblionumber %]\');\">Edit<\/a><\/p>" >+ "<a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=[% biblionumber |uri%]\');\">Edit<\/a><\/p>" > ); > parent.opener.$("#addcomment").prev("p").remove(); > parent.opener.$("#addcomment").remove(); >@@ -66,7 +66,7 @@ > </div> > [% END %] > <form id="reviewf" action="/cgi-bin/koha/opac-review.pl[% IF ( cgi_debug ) %]?debug=1[% END %]" method="post"> >- <input type="hidden" name="biblionumber" value="[% biblionumber %]" /> >+ <input type="hidden" name="biblionumber" value="[% biblionumber | html%]" /> > <fieldset class="brief"> > <legend>Comments on <i>[% title |html %] [% subtitle %]</i>[% IF ( author ) %]by [% author %][% END %]</legend> > <ol><li><textarea id="review" name="review" cols="60" rows="8">[% review %]</textarea></li></ol> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tt >index 8d6b94b..5d45b53 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tt >@@ -12,9 +12,9 @@ > <div id="userserialissues" class="container"> > <h2>Issues for a subscription</h2> > <div id="views"> >- <span class="view"><a id="Normalview" href="opac-detail.pl?biblionumber=[% biblionumber %]" class="button">Normal View</a></span> >+ <span class="view"><a id="Normalview" href="opac-detail.pl?biblionumber=[% biblionumber | html %]" class="button">Normal View</a></span> > <span class="view"><span id="Briefhistory">Brief history</span></span> >- <span class="view"><a id="Fullhistory" href="opac-serial-issues.pl?selectview=full&biblionumber=[% biblionumber %]" class="button">Full History</a></span> >+ <span class="view"><a id="Fullhistory" href="opac-serial-issues.pl?selectview=full&biblionumber=[% biblionumber | html%]" class="button">Full History</a></span> > </div> > <form method="post" name="f"> > [% FOREACH subscription_LOO IN subscription_LOOP %] >-- >1.7.4.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6518
:
4503
| 4504