From 6da1798de099a77281752f21d191a0a5c1938f41 Mon Sep 17 00:00:00 2001 From: Paul Poulain Date: Wed, 29 Jun 2011 22:37:38 +0200 Subject: [PATCH] follow-up of rebased patch : fixing Perl warnings --- misc/cronjobs/overdue_notices.pl | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 40d83f5..8353194 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -281,14 +281,15 @@ GetOptions( pod2usage(1) if $help; pod2usage( -verbose => 2 ) if $man; -my $columns_def_hashref = C4::Reports::Guided::_get_column_defs(); +my $cgi = new CGI; # this CGI is useless, except to avoid an error +my $columns_def_hashref = C4::Reports::Guided::_get_column_defs($cgi); foreach my $key ( keys %$columns_def_hashref ) { my $initkey = $key; $key =~ s/[^\.]*\.//; $columns_def_hashref->{$key} = $columns_def_hashref->{$initkey}; } -print Dump($columns_def_hashref); + if ( defined $csvfilename && $csvfilename =~ /^-/ ) { warn qq(using "$csvfilename" as filename, that seems odd); } @@ -698,7 +699,7 @@ sub parse_letter { # FIXME: this code should probably be moved to C4::Letters:pa PROCESS_ITEMS: while (scalar(@{$params->{'items'}}) > 0) { my $item = shift @{$params->{'items'}}; - my $fine = GetFine($item->{'itemnumber'}, $params->{'borrowernumber'}); + my $fine = GetFine($item->{'itemnumber'}, $params->{'borrowernumber'})||0; if (!$item_format) { $params->{'letter'}->{'content'} =~ m/(.*<\/item>)/; $item_format = $1; -- 1.7.4.1