Bugzilla – Attachment 45723 Details for
Bug 10163
batch-mod items tool fails on files over 1000 lines long
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10163 - batch-mod items tool fails on files over 1000 lines long
SIGNED-OFF-Bug-10163---batch-mod-items-tool-fails-.patch (text/plain), 2.69 KB, created by
Owen Leonard
on 2015-12-16 13:46:53 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10163 - batch-mod items tool fails on files over 1000 lines long
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2015-12-16 13:46:53 UTC
Size:
2.69 KB
patch
obsolete
>From a68ad66498c1a304791b08300b516f6c32c6f27f Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 2 Dec 2015 14:44:26 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 10163 - batch-mod items tool fails on files > over 1000 lines long >Content-Type: text/plain; charset="utf-8" > >When using batch modification tool, if number of items is too big >(default 1000), the edit form is not displayed. > >In perl script, when number of items is too big, template var >"item_loop" is not defined and var "too_many_items"is set. > >This patch allows the display of edit form and text "The following >barcodes were found: " even when number of items is too big. > >Test plan : >- Create a file with 11 existing barcodes and 1 not existing in > catalogue >- Set syspref MaxItemsForBatch to 1000 >- Go to Tools > Batch item modification >- Select "Barcode file" and upload file >- Click on continue > => you see a warning with the not found barcode, a table with found > items and the edit form >- Set syspref MaxItemsForBatch to 10 >- Go to Tools > Batch item modification >- Select "Barcode file" and upload file >- Click on continue > => you see a warning with the not found barcode and a text "Too many > items ..." > => Without patch you don't see the edit form > => With patch you see the edit form and can perform the batc > modifications > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Test plan followed successfully. Item modifications completed correctly. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >index 38a76ce..cbd050f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >@@ -79,10 +79,8 @@ $(document).ready(function(){ > [% END %] > </tbody> > </table> >- [% IF ( item_loop ) %] >- [% UNLESS ( too_many_items ) %] >- <h4>The following barcodes were found: </h4> >- [% END %] >+ [% IF ( item_loop || too_many_items ) %] >+ <h4>The following barcodes were found: </h4> > [% END %] > [% END %] <!-- /notfoundbarcodes --> > >@@ -160,7 +158,7 @@ $(document).ready(function(){ > [% END %] > [% END %]<!-- /too_many_items --> > >-[% IF ( item_loop ) %] >+[% IF ( item_loop || too_many_items ) %] > <div id="cataloguing_additem_newitem"> > <h2>Edit Items</h2> > <div class="hint">Checking the box right next the subfield label will disable the entry and delete the subfield on all selected items. Leave fields blank to make no change.</div> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10163
:
17859
|
18256
|
20056
|
45326
| 45723