Bugzilla – Attachment 46028 Details for
Bug 15345
Translatability: fix issue in facets (Availability')
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15345: Translatability: fix issue in facets (Availability')
-Bug-15345-Translatability-fix-issue-in-facets-Ava.patch (text/plain), 4.08 KB, created by
Brendan Gallagher
on 2015-12-29 20:24:58 UTC
(
hide
)
Description:
Bug 15345: Translatability: fix issue in facets (Availability')
Filename:
MIME Type:
Creator:
Brendan Gallagher
Created:
2015-12-29 20:24:58 UTC
Size:
4.08 KB
patch
obsolete
>From 5e80a64ea39140c9918335fc472a441bb3fa9c6a Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Wed, 9 Dec 2015 18:36:21 +0100 >Subject: [PATCH] Bug 15345: Translatability: fix issue in facets > (Availability') >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch fixes an issue with a splitted sentence in facets (Avalability) >that leads to weird translations e.g.: >German: 'Zeige nur Verfügbar Exemplare' >French: 'Montrer seulement disponible exemplaires' > >Additionally, the link "Show all items" gets it's own li tags to display >nicely like the other links in the facets column and it removes superfluous >dots. > >To test in OPAC and Staff client: >- Apply patch >- Do a search that results in more than one available items >- In column "Refine your search", click on "Limit to currently available > items" >- Verify that the message "Showing only available items" and the link > "Show all items" display nicely. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >use_zebra_facets set to 0 in koha-conf.xml to test. Works as described > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >index d0abde9..3d0d15e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >@@ -3,7 +3,7 @@ > <div id="search-facets"> > <h4>Refine your search</h4> > <ul> >- <li id="availability_facet">Availability<ul><li>[% IF ( available ) %]Showing only <strong>available</strong> items. <a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi |html %][% limit_cgi_not_availablity %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]">Show all items</a>[% ELSE %]Limit to <a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi |html %][% limit_cgi |html %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]&limit=available">currently available items.</a>[% END %]</li></ul> >+ <li id="availability_facet">Availability<ul><li>[% IF ( available ) %]<strong>Showing only available items</strong></li><li><a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi |html %][% limit_cgi_not_availablity %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]">Show all items</a>[% ELSE %]<a href="/cgi-bin/koha/catalogue/search.pl?[% query_cgi |html %][% limit_cgi |html %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]&limit=available">Limit to currently available items</a>[% END %]</li></ul> > [% IF ( related ) %] <li>(related searches: [% FOREACH relate IN related %][% relate.related_search %][% END %])</li>[% END %] > </li> > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >index 3d503aa..769145f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc >@@ -6,7 +6,7 @@ > <ul> > <li> > [% IF ( available ) %] >- Showing only <strong>available</strong> items. <a href="/cgi-bin/koha/opac-search.pl?[% query_cgi %][% limit_cgi_not_availablity %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]">Show all items</a> >+ <strong>Showing only available items<strong></li><li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi %][% limit_cgi_not_availablity %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]">Show all items</a> > [% ELSE %] > <a href="/cgi-bin/koha/opac-search.pl?[% query_cgi %][% limit_cgi |url %][% IF ( sort_by ) %]&sort_by=[% sort_by |url %][% END %]&limit=available">Limit to currently available items.</a> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15345
:
45555
|
45557
|
45624
| 46028