Lines 8-14
use t::lib::TestBuilder;
Link Here
|
8 |
use C4::Context; |
8 |
use C4::Context; |
9 |
use C4::Branch; |
9 |
use C4::Branch; |
10 |
|
10 |
|
11 |
use Test::More tests => 56; |
11 |
use Test::More tests => 59; |
12 |
use MARC::Record; |
12 |
use MARC::Record; |
13 |
use C4::Biblio; |
13 |
use C4::Biblio; |
14 |
use C4::Items; |
14 |
use C4::Items; |
Lines 314-323
ModReserve({ reserve_id => $reserveid2, rank => 'del' });
Link Here
|
314 |
$reserve3 = GetReserve( $reserveid3 ); |
314 |
$reserve3 = GetReserve( $reserveid3 ); |
315 |
is( $reserve3->{priority}, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" ); |
315 |
is( $reserve3->{priority}, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" ); |
316 |
|
316 |
|
|
|
317 |
ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" ); |
318 |
|
317 |
ModItem({ damaged => 1 }, $item_bibnum, $itemnumber); |
319 |
ModItem({ damaged => 1 }, $item_bibnum, $itemnumber); |
|
|
320 |
CancelReserve({reserve_id => $reserveid3}); |
318 |
C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 1 ); |
321 |
C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 1 ); |
319 |
ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" ); |
322 |
ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" ); |
320 |
ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" ); |
|
|
321 |
C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 0 ); |
323 |
C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 0 ); |
322 |
ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" ); |
324 |
ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" ); |
323 |
ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" ); |
325 |
ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" ); |
Lines 332-354
AddReserve(
Link Here
|
332 |
'', |
334 |
'', |
333 |
1, |
335 |
1, |
334 |
); |
336 |
); |
|
|
337 |
my ($bibnum2, $title2, $bibitemnum2) = create_helper_biblio('CANNOT'); |
338 |
my ($item_bibnum2, $item_bibitemnum2, $itemnumber2) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $bibnum2); |
335 |
ok( |
339 |
ok( |
336 |
CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'tooManyReserves', |
340 |
CanItemBeReserved( $borrowernumbers[0], $itemnumber2) eq 'tooManyReserves', |
337 |
"cannot request item if policy that matches on item-level item type forbids it" |
341 |
"cannot request item if policy that matches on item-level item type forbids it" |
338 |
); |
342 |
); |
339 |
ModItem({ itype => 'CAN' }, $item_bibnum, $itemnumber); |
343 |
ModItem({ itype => 'CAN' }, $item_bibnum2, $itemnumber2); |
340 |
ok( |
344 |
ok( |
341 |
CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'OK', |
345 |
CanItemBeReserved( $borrowernumbers[0], $itemnumber2) eq 'OK', |
342 |
"can request item if policy that matches on item type allows it" |
346 |
"can request item if policy that matches on item type allows it" |
343 |
); |
347 |
); |
344 |
|
348 |
|
345 |
t::lib::Mocks::mock_preference('item-level_itypes', 0); |
349 |
t::lib::Mocks::mock_preference('item-level_itypes', 0); |
346 |
ModItem({ itype => undef }, $item_bibnum, $itemnumber); |
350 |
ModItem({ itype => undef }, $item_bibnum2, $itemnumber2); |
347 |
ok( |
351 |
ok( |
348 |
CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'tooManyReserves', |
352 |
CanItemBeReserved( $borrowernumbers[0], $itemnumber2) eq 'tooManyReserves', |
349 |
"cannot request item if policy that matches on bib-level item type forbids it (bug 9532)" |
353 |
"cannot request item if policy that matches on bib-level item type forbids it (bug 9532)" |
350 |
); |
354 |
); |
351 |
|
355 |
|
|
|
356 |
is(CanBookBeReserved($borrowernumbers[0], $bibnum), 'alreadyReserved'); |
357 |
|
358 |
C4::Context->set_preference('maxreserves', 1); |
359 |
ok(CanBookBeReserved($borrowernumbers[0], $biblionumber) eq 'tooManyReserves'); |
360 |
|
361 |
C4::Context->set_preference('maxreserves', 0); |
362 |
t::lib::Mocks::mock_preference('IndependentBranches', 1); |
363 |
t::lib::Mocks::mock_preference('canreservefromotherbranches', 0); |
364 |
ok(CanBookBeReserved($borrowernumbers[0], $foreign_bibnum) eq 'none_available'); |
352 |
|
365 |
|
353 |
# Test branch item rules |
366 |
# Test branch item rules |
354 |
|
367 |
|
Lines 458-467
sub create_helper_biblio {
Link Here
|
458 |
my $itemtype = shift; |
471 |
my $itemtype = shift; |
459 |
my $bib = MARC::Record->new(); |
472 |
my $bib = MARC::Record->new(); |
460 |
my $title = 'Silence in the library'; |
473 |
my $title = 'Silence in the library'; |
461 |
$bib->append_fields( |
474 |
if (C4::Context->preference('marcflavour') eq 'UNIMARC') { |
462 |
MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'), |
475 |
$bib->append_fields( |
463 |
MARC::Field->new('245', ' ', ' ', a => $title), |
476 |
MARC::Field->new('700', ' ', '0', a => 'Moffat, Steven'), |
464 |
MARC::Field->new('942', ' ', ' ', c => $itemtype), |
477 |
MARC::Field->new('200', ' ', ' ', a => $title), |
465 |
); |
478 |
MARC::Field->new('099', ' ', ' ', t => $itemtype), |
466 |
return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, ''); |
479 |
); |
|
|
480 |
} else { |
481 |
$bib->append_fields( |
482 |
MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'), |
483 |
MARC::Field->new('245', ' ', ' ', a => $title), |
484 |
MARC::Field->new('942', ' ', ' ', c => $itemtype), |
485 |
); |
486 |
} |
487 |
|
488 |
return AddBiblio($bib, ''); |
467 |
} |
489 |
} |
468 |
- |
|
|