From 47c638bbb03c25d1450d46fea27fdc81688535ab Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 5 Jan 2016 14:25:35 +0000 Subject: [PATCH] Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Prior to this patch, the itemtypes were displayed ordered by the code (itemtypes.itemtype DB column). This patch will make them displayed by the description displayed (the translated description). Test plan: 0/ Do not apply this patch set 1/ Confirm that the itemtypes are displayed ordered by code (when adding an item, cataloguing/additem.pl) 2/ Confirm that t/db_dependent/Koha.t does not pass 3/ Apply the test patch 4/ Confirm that t/db_dependent/Koha.t pass 5/ Confirm that the itemtypes are not displayed by description (on additem.pl) See comment #3 Signed-off-by: Marc VĂ©ron --- C4/Koha.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Koha.pm b/C4/Koha.pm index 12ac19c..8959010 100644 --- a/C4/Koha.pm +++ b/C4/Koha.pm @@ -249,7 +249,6 @@ sub GetItemTypes { require C4::Languages; my $language = C4::Languages::getlanguage(); # returns a reference to a hash of references to itemtypes... - my %itemtypes; my $dbh = C4::Context->dbh; my $query = q| SELECT @@ -275,12 +274,13 @@ sub GetItemTypes { $sth->execute( $language ); if ( $style eq 'hash' ) { + my %itemtypes; while ( my $IT = $sth->fetchrow_hashref ) { $itemtypes{ $IT->{'itemtype'} } = $IT; } return ( \%itemtypes ); } else { - return $sth->fetchall_arrayref({}); + return [ sort { lc $a->{translated_description} cmp lc $b->{translated_description} } @{ $sth->fetchall_arrayref( {} ) } ]; } } -- 1.7.10.4