From a24e80fcf36d8b4b61857524df7d2165b6cf1ac5 Mon Sep 17 00:00:00 2001 From: Olli-Antti Kivilahti Date: Tue, 20 Jan 2015 20:49:18 +0200 Subject: [PATCH] Bug 5501 - Improve the 'do not notify' option. HOLD-letter. TEST PLAN: 1. Find a Borrower and edit "Patron messaging preferences". 2. Check the "Do not notify" for "Hold filled" -letter. 3. Check any other checkboxes for "Hold filled" -letter. The "Do not notify"-checkbox should get unchecked. 4. Check the "Do not notify" -checkbox again for the "Hold filled" -letter. Other selections for the row get unchecked. 5. Save changes. 6. Make a hold for a borrower. 7. Check-in the reserved Item and catch the hold. 8. In the notices-tab for the Borrower, there should be no message for the borrower about getting the caught Hold. Signed-off-by: Aleisha --- C4/Reserves.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 7bb5d69..b6b9c8d 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -1982,6 +1982,9 @@ sub _koha_notify_reserve { message_name => 'Hold_Filled' } ); + #The Borrower can opt out from any notifications. This is explicit rejection. + return if $messagingprefs->{transports}->{none}; + my $sth = $dbh->prepare(" SELECT * FROM reserves -- 1.7.10.4