From d775e3179cf26d3861ba69c0d40cad75995b9d02 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 13 Jan 2016 16:13:36 +0000 Subject: [PATCH] Bug 15568: Fix display default circ rules To reproduce: Go on the admin circ rules page (admin/smart-rules.pl), switch the dropdown list from specific to "all libraries". The rules are not displayed anymore. Test plan: Apply this patch and confirm that the rules are now displayed correctly. Make sure the enh introduced by bug 11625 is not broken. This patch also replaces a call to the removed method C4::Branches::GetBranchesCoutn with a call to Koha::Libraries->search-count --- admin/smart-rules.pl | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl index 9c903da..e120bd8 100755 --- a/admin/smart-rules.pl +++ b/admin/smart-rules.pl @@ -30,6 +30,7 @@ use Koha::DateUtils; use Koha::Database; use Koha::IssuingRule; use Koha::IssuingRules; +use Koha::Libraries; my $input = CGI->new; my $dbh = C4::Context->dbh; @@ -47,12 +48,14 @@ my ($template, $loggedinuser, $cookie) my $type=$input->param('type'); -my $branch; -if ( C4::Context->preference('DefaultToLoggedInLibraryCircRules') ) { - $branch = $input->param('branch') || GetBranchesCount() == 1 ? undef : C4::Branch::mybranch(); -} -else { - $branch = $input->param('branch') || ( C4::Branch::onlymine() ? ( C4::Branch::mybranch() || '*' ) : '*' ); +my $branch = $input->param('branch'); +unless ( $branch ) { + if ( C4::Context->preference('DefaultToLoggedInLibraryCircRules') ) { + $branch = Koha::Libraries->search->count() == 1 ? undef : C4::Branch::mybranch(); + } + else { + $branch = C4::Branch::onlymine() ? ( C4::Branch::mybranch() || '*' ) : '*'; + } } $branch = '*' if $branch eq 'NO_LIBRARY_SET'; -- 2.1.4