Bugzilla – Attachment 47425 Details for
Bug 13618
Add additional template filter methods and a filter presence test to Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13618: Use Template::Stash::AutoEscaping to use the html filter
Bug-13618-Use-TemplateStashAutoEscaping-to-use-the.patch (text/plain), 3.36 KB, created by
Jonathan Druart
on 2016-01-29 09:53:44 UTC
(
hide
)
Description:
Bug 13618: Use Template::Stash::AutoEscaping to use the html filter
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-01-29 09:53:44 UTC
Size:
3.36 KB
patch
obsolete
>From d3720442016c5a56365a00c6ce5118ea2503f10f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 23 Jan 2015 13:18:54 +0100 >Subject: [PATCH] Bug 13618: Use Template::Stash::AutoEscaping to use the html > filter >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan: >0/ sudo cpanm Template::Stash::AutoEscaping >1/ Verify don't reproduce the XSS issue described on bug 13609 and other >xss related bugs. >2/ Try to find some encoding issues (detail page, search results, >facets, etc.) > >Signed-off-by: Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Installer/PerlDependencies.pm | 5 +++++ > C4/Templates.pm | 2 ++ > .../bootstrap/en/modules/opac-authoritiessearchresultlist.tt | 6 +++--- > 3 files changed, 10 insertions(+), 3 deletions(-) > >diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm >index d621f33..be84077 100644 >--- a/C4/Installer/PerlDependencies.pm >+++ b/C4/Installer/PerlDependencies.pm >@@ -822,6 +822,11 @@ our $PERL_DEPS = { > 'required' => '0', > 'min_ver' => '0.03', > }, >+ 'Template::Stash::AutoEscaping' => { >+ 'usage' => 'Code', >+ 'required' => '1', >+ 'min_ver' => '0.0303', >+ }, > }; > > 1; >diff --git a/C4/Templates.pm b/C4/Templates.pm >index 4f23dc7..0528217 100644 >--- a/C4/Templates.pm >+++ b/C4/Templates.pm >@@ -5,6 +5,7 @@ use warnings; > use Carp; > use CGI qw ( -utf8 ); > use List::MoreUtils qw/ any uniq /; >+use Template::Stash::AutoEscaping; > > # Copyright 2009 Chris Cormack and The Koha Dev Team > # >@@ -69,6 +70,7 @@ sub new { > COMPILE_DIR => $use_template_cache ? C4::Context->config('template_cache_dir') : '', > INCLUDE_PATH => \@includes, > FILTERS => {}, >+ STASH => Template::Stash::AutoEscaping->new, > ENCODING => 'UTF-8', > } > ) or die Template->error(); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt >index 4ebaac6..6ded40c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt >@@ -1,7 +1,7 @@ > [% USE Koha %] > [% PROCESS 'opac-authorities.inc' %] > [% PROCESS 'authorities-search-results.inc' %] >-[% pagination = BLOCK %] >+[% BLOCK pagination %] > <div class="pagination"> > <ul> > [% IF ( displayprev ) %] >@@ -56,7 +56,7 @@ > <div id="userauthsearchresults" class="maincontent"> > <h1>Authority search results</h1> > >- [% pagination %] >+ [% PROCESS pagination %] > > <div id="results"> > [% IF ( total ) %] >@@ -102,7 +102,7 @@ > </table> > </div> <!-- / .searchresults --> > >- [% pagination %] >+ [% PROCESS pagination %] > > [% END # / IF total %] > </div> <!-- / #userauthsearchresults --> >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13618
:
35488
|
35516
|
40480
|
40481
|
40482
|
40483
|
40484
|
40485
|
40487
|
41346
|
41347
|
41348
|
41349
|
41350
|
41351
|
41352
|
41353
|
41354
|
41355
|
41746
|
41747
|
41776
|
42009
|
42054
|
42072
|
42073
|
42075
|
42078
|
42079
|
42087
|
42090
|
42091
|
42092
|
42093
|
42094
|
42095
|
42096
|
42097
|
45141
|
45784
|
45785
|
45788
|
46767
|
46768
|
46769
|
46770
|
46771
|
46772
|
46773
|
46774
|
46775
|
46776
|
46777
|
46778
|
46779
|
46780
|
46781
|
46782
|
46783
|
46784
|
46785
|
46786
|
46787
|
46788
|
46789
|
46790
|
46791
|
46792
|
46793
|
46794
|
46795
|
46796
|
46797
|
46798
|
46799
|
46800
|
46801
|
46802
|
46803
|
46804
|
46805
|
46806
|
46807
|
46808
|
46809
|
46810
|
46811
|
46812
|
46813
|
46814
|
46815
|
46816
|
46817
|
46818
|
46819
|
46820
|
46821
|
46822
|
47425
|
47426
|
47427
|
47428
|
47429
|
47430
|
47431
|
47432
|
47433
|
47434
|
47435
|
47436
|
47437
|
47438
|
47439
|
47440
|
47441
|
47442
|
47443
|
47444
|
47445
|
47446
|
47447
|
47448
|
47449
|
47450
|
47451
|
47452
|
47631
|
59983
|
59984
|
59987
|
77804
|
77805
|
77806
|
77807
|
77808
|
77809
|
77997
|
77998
|
78158
|
78274
|
78415
|
79404
|
79818
|
81183
|
83479
|
83480