From 2d87625a74973ccd3817c736abd23e156bc01b6b Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Wed, 10 Feb 2016 21:51:26 -0500 Subject: [PATCH] [SIGNED-OFF] Bug 15795: C4/Members.pm is floody (Norwegian Patron DB) From the mailing list: "I'm working on 3.22.02 and my logs are FILLED with the following warnings: Members.pm: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl admin-home.pl: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/admin/preferences.pl" I agree. Looking at C4/Members.pm other warns are all prepended with $debug. TEST PLAN --------- 1) rm Koha/NorwegianPatronDB.pm -- quickest and dirtiest way to get the load to fail. 2) echo > ~/koha-dev/var/log/koha-error_log -- so it will be easy to spot the log changes. -- back up the log file if you really want it. 3) log into the staff client and go to patrons. -- Check the log file. "Unable to load ..." will be there. 4) echo > ~/koha-dev/var/log/koha-error_log 5) sudo vi /etc/apache2/sites-enabled/{your koha site file} -- Find your staff client entry in your apache configuration file and add: SetEnv DEBUG 1 6) sudo service apache2 restart 7) apply the patch 8) refresh the patron page -- "Unable to load..." will still be there. 9) change the DEBUG value in your apache config to 0 10) sudo sevice apache2 restart 11) echo > ~/koha-dev/var/log/koha-error_log 12) refresh the patron page -- "Unable to load..." will NOT be there. 13) git checkout origin/master -- Koha/NorwegianPatronDB.pm -- to bring it back. 14) refresh the patron page -- "Unable to load..." will still not be there. 15) run koha qa test tools Signed-off-by: Philippe Blouin --- C4/Members.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index 4ba1f19..f3376b7 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -41,12 +41,13 @@ use Text::Unaccent qw( unac_string ); use Koha::AuthUtils qw(hash_password); use Koha::Database; +our ($VERSION,@ISA,@EXPORT,@EXPORT_OK,$debug); + use Module::Load::Conditional qw( can_load ); if ( ! can_load( modules => { 'Koha::NorwegianPatronDB' => undef } ) ) { - warn "Unable to load Koha::NorwegianPatronDB"; + $debug && warn "Unable to load Koha::NorwegianPatronDB"; } -our ($VERSION,@ISA,@EXPORT,@EXPORT_OK,$debug); BEGIN { $VERSION = 3.07.00.049; -- 2.1.0