From b5d12e5377f0396a8ae15ae626c0b4eb636c9250 Mon Sep 17 00:00:00 2001 From: Chris Cormack Date: Mon, 8 Aug 2011 20:29:05 +1200 Subject: [PATCH] Bug 6679 : Fixing a style error to pass Perl::Critic, plus silencing a warn --- acqui/addorderiso2709.pl | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl index c46263a..10db7ba 100755 --- a/acqui/addorderiso2709.pl +++ b/acqui/addorderiso2709.pl @@ -210,8 +210,14 @@ if ($op eq ""){ } if ($price){ $orderinfo{'listprice'} = $price; - eval "use C4::Acquisition qw/GetBasket/;"; - eval "use C4::Bookseller qw/GetBookSellerFromId/;"; + eval {"use C4::Acquisition qw/GetBasket/;";}; + if ($@){ + croak $@; + } + eval {"use C4::Bookseller qw/GetBookSellerFromId/;";}; + if ($@){ + croak $@; + } my $basket = GetBasket( $orderinfo{basketno} ); my $bookseller = GetBookSellerFromId( $basket->{booksellerid} ); my $gst = $bookseller->{gstrate} || C4::Context->preference("gist") || 0; @@ -265,7 +271,7 @@ my $budget = GetBudget($budget_id); # build budget list my $budget_loop = []; -my $budgets = GetBudgetHierarchy( q{}, $borrower->{branchcode}, $borrower->{borrowernumber} ); +$budgets = GetBudgetHierarchy( q{}, $borrower->{branchcode}, $borrower->{borrowernumber} ); foreach my $r ( @{$budgets} ) { if ( !defined $r->{budget_amount} || $r->{budget_amount} == 0 ) { next; -- 1.7.4.1