From dd67ee99ed95c798f01a334b667d59fdb677ce9c Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 21 Mar 2016 10:47:56 -0400 Subject: [PATCH] Bug 14582 - OPAC detail shows an unuseful link to "add tag" when user is not logged in Content-Type: text/plain; charset="utf-8" This patch rearranges some parts of the OPAC detail page template so that the "add tag" link does not appear if the user is not logged in. This patch also includes some whitespace changes, so please diff accordingly. To test, apply the patch and set "TagsEnabled" to "Allow." - With "TagsInputOnDetail" set to "Allow," view the detail page for a bibliographic record in the OPAC when /not/ logged in. You should see a "Log in to add tags" link which triggers the login modal when clicked. - Log in and view the same page. Confirm that there is now an "Add tag(s)" link which triggers the add tags form. Confirm that the behavior of the add tags form is still correct. - With "TagsInputOnDetail" set to "Don't allow" view the detail page again and verify that the "Log in to add tags" link doesn't appear when not logged in, and the "Add tags" link doesn't appear when logged in. --- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 57 ++++++++++------------ 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 6bdcc47..ac7a93c 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -397,39 +397,36 @@ [% IF ( TagsShowEnabled ) %]
- [% IF ( TagLoop ) %] - Tags from this library: - - [% ELSE %] - Tags from this library: No tags from this library for this title. - [% END %] - [% IF ( TagsInputEnabled ) %] Add tag(s) [% END %] -
- [% END # /IF TagsShowEnabled %] - - [% IF ( TagsInputEnabled ) %] -
- [% IF ( loggedinusername ) %] - - + [% IF ( TagLoop ) %] + Tags from this library: + [% ELSE %] - Log in to add tags. + Tags from this library: No tags from this library for this title. [% END %] + [% IF ( TagsInputEnabled ) %] + [% IF ( loggedinusername ) %] + + + Add tag(s) + [% ELSE %] + Log in to add tags. + [% END %] + [% END # / IF TagsInputEnabled %]
- [% END # / IF TagsInputEnabled %] + [% END # /IF TagsShowEnabled %] [% IF ( SyndeticsEnabled ) %] [% IF ( SyndeticsSeries && SyndeticsSERIES1Exists ) %] -- 2.1.4