From f6518f66c5c32a773a3c8a15c3bc4ce2645b7d92 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 18 Mar 2016 14:11:11 +0100 Subject: [PATCH] Bug 16103: Remove FK sms_provider_id in deletedborrowers This patch removes the FK constraint for sms_provider_id in table deletedborrowers. (We do not need FKs in that table.) It just corrects a newly added db revision in updatedatabase. If this is pushed before releasing master, no need to do anything more. Note that this key was not found in kohastructure and the DBIx schema. Edit: To test: - With master DB run $ prove t/db_dependent/TestBuilder.t => SUCCESS: Tests pass - Create a clean 3.22.00 DB - Run the upgrade process $ perl installer/data/mysql/updatedatabase.pl - Run $ prove t/db_dependent/TestBuilder.t => FAIL: Tests fail due to discrepancies in DB structure - Re-create teh clean 3.22.00 DB - Apply the patch - Run the upgrade process $ perl installer/data/mysql/updatedatabase.pl - Run $ prove t/db_dependent/TestBuilder.t => SUCCESS: Tests now pass Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi --- installer/data/mysql/updatedatabase.pl | 3 --- 1 file changed, 3 deletions(-) diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index cbad1fe..137ae6c 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -11755,9 +11755,6 @@ if ( CheckVersion($DBversion) ) { $dbh->do(q{ ALTER TABLE deletedborrowers ADD sms_provider_id INT( 11 ) NULL DEFAULT NULL AFTER smsalertnumber; }); - $dbh->do(q{ - ALTER TABLE deletedborrowers ADD FOREIGN KEY ( sms_provider_id ) REFERENCES sms_providers ( id ) ON UPDATE CASCADE ON DELETE SET NULL; - }); print "Upgrade to $DBversion done (Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers)\n"; SetVersion($DBversion); -- 2.7.4