From 499cf4da81c402a21123a2f76a875232d28be0e4 Mon Sep 17 00:00:00 2001 From: Mason James Date: Fri, 1 Apr 2016 15:23:22 +1300 Subject: [PATCH] [PASSED QA] Bug 1750 - Report bor_issues_top erroneous and truncated results. Signed-off-by: Mason James TEST PLAN --------- 1) Ensure you have some checkouts 2) Home -> Reports -> Patrons with the most checkouts 3) Click 'Submit' -- you get a list 4) Click a patron name. 5) Note the borrower number. 6) In MySQL run something like: > UPDATE borrower SET firstname=NULL WHERE borrowernumber=#### 7) Refresh the report page -- name goes totally blank 8) apply patch 9) Refresh the report page -- only first name is lost 10) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer --- reports/bor_issues_top.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl index e230a10..8253fee 100755 --- a/reports/bor_issues_top.pl +++ b/reports/bor_issues_top.pl @@ -279,7 +279,7 @@ sub calculate { my $strcalc ; # Processing average loanperiods - $strcalc .= "SELECT CONCAT(borrowers.surname , \",\\t\",borrowers.firstname), COUNT(*) AS RANK, borrowers.borrowernumber AS ID"; + $strcalc .= "SELECT CONCAT_WS('', borrowers.surname , \",\\t\", borrowers.firstname), COUNT(*) AS RANK, borrowers.borrowernumber AS ID"; $strcalc .= " , $colfield " if ($colfield); $strcalc .= " FROM `old_issues` LEFT JOIN borrowers USING(borrowernumber) -- 1.9.1