From 9374cf42fa5ee74b576f2ae7b296712769663b6f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 7 Apr 2016 10:13:43 +0100 Subject: [PATCH] [SIGNED-OFF] Bug 15757: Make issuelength default to null instead of 0 When editing circ rules, if the Loan period "issuelength" is not defined (empty string), the default value was 0, not it's inserted in the DB as NULL. Test plan: 1/ Create or edit a circ rule 2/ Do not fill the Loan period column 3/ Save => Without this patch, the value was 0 => With this patch it's now an empty string (in the DB it's set to NULL) Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No errors --- admin/smart-rules.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl index da4e577..ade2993 100755 --- a/admin/smart-rules.pl +++ b/admin/smart-rules.pl @@ -140,6 +140,7 @@ elsif ($op eq 'add') { $maxonsiteissueqty =~ s/\s//g; $maxonsiteissueqty = undef if $maxonsiteissueqty !~ /^\d+/; my $issuelength = $input->param('issuelength'); + $issuelength = $issuelength eq q{} ? undef : $issuelength; my $lengthunit = $input->param('lengthunit'); my $hardduedate = $input->param('hardduedate') || undef; $hardduedate = eval { dt_from_string( $input->param('hardduedate') ) } if ( $hardduedate ); -- 1.9.1