Bugzilla – Attachment 50222 Details for
Bug 16179
Clicking Rate me button in OPAC without selecting rating produces error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 16179: Do not crash if "rate me" is clicked and not rate selected
PASSED-QA-Bug-16179-Do-not-crash-if-rate-me-is-cli.patch (text/plain), 1.75 KB, created by
Katrin Fischer
on 2016-04-14 05:45:07 UTC
(
hide
)
Description:
[PASSED QA] Bug 16179: Do not crash if "rate me" is clicked and not rate selected
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-04-14 05:45:07 UTC
Size:
1.75 KB
patch
obsolete
>From 30e3d7c99e8c9d173ae0ae313a11bd7ffb85ccc1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 4 Apr 2016 14:45:48 +0100 >Subject: [PATCH] [PASSED QA] Bug 16179: Do not crash if "rate me" is clicked > and not rate selected > >If JS is disabled and a user clicks on the "Rate me" button, Koha will >crashes with: >DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null >at /usr/share/koha/lib/C4/Ratings.pm line 208 > >To avoid that, opac-ratings.pl will check if a rate has been selected. > >Test plan: >Disable JS >On a record detail page, click on the "Rate me" button > >TESTED PLAN: >1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1 > -- kaboom as above. >2) apply patch >3) refresh > -- either login screen (don't know why) > -- or if already logged in, detail page. >4) koha qa test tool > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >I tested successfully by temporarily removing the modification made by >Bug 16210. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > opac/opac-ratings.pl | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/opac/opac-ratings.pl b/opac/opac-ratings.pl >index 2ad0cb0..23e73da 100755 >--- a/opac/opac-ratings.pl >+++ b/opac/opac-ratings.pl >@@ -45,6 +45,13 @@ my $rating_old_value = $query->param('rating_value'); > my $rating_value = $query->param('rating'); > my $rating; > >+# If JS is disabled and a user click on "Rate me" without selecting a rate >+unless ( $biblionumber and $rating_value ) { >+ print $query->redirect( >+ "/cgi-bin/koha/opac-detail.pl?biblionumber=$biblionumber"); >+ exit; >+} >+ > if ( !$rating_old_value ) { > $rating = AddRating( $biblionumber, $loggedinuser, $rating_value ); > } >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16179
:
49858
|
49936
|
50030
| 50222