Bugzilla – Attachment 50706 Details for
Bug 16268
Add confirm message when deleting circ and fines rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16268: Add confirm message for deleting circ and fines rules
Bug-16268-Add-confirm-message-for-deleting-circ-an.patch (text/plain), 4.79 KB, created by
Marc Véron
on 2016-04-26 04:23:57 UTC
(
hide
)
Description:
Bug 16268: Add confirm message for deleting circ and fines rules
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-04-26 04:23:57 UTC
Size:
4.79 KB
patch
obsolete
>From 9298d293b42a083705854377862c6fc8a8020b43 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Sun, 17 Apr 2016 22:35:19 +0000 >Subject: [PATCH] Bug 16268: Add confirm message for deleting circ and fines > rules >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >EDIT: Removes unnecessary code and uses confirm message in staff-global.js > >To test: >1) Apply 16267 >2) Go to Admin -> Circ and fines rules >3) Try clicking on Delete and Unset buttons >4) Confirm a confirm message pops up and works as expected > >Sponsored-by: Catalyst IT > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index b8b9dfd..58425c1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -25,7 +25,13 @@ function clear_edit(){ > $(edit_row).find("td:last input[name='clear']").remove(); > } > >+var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this rule? This cannot be undone."); >+ > $(document).ready(function() { >+ $(".delete").on("click",function(){ >+ return confirmDelete(MSG_CONFIRM_DELETE); >+ }); >+ > $('#cap_fine_to_replacement_price').on('change', function(){ > $('#overduefinescap').prop('disabled', $(this).is(':checked') ); > }); >@@ -253,7 +259,7 @@ for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidde > <td>[% rule.rentaldiscount %]</td> > <td class="actions"> > <a href="#" class="editrule btn btn-mini"><i class="fa fa-pencil"></i> Edit</a> >- <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&itemtype=[% rule.itemtype %]&categorycode=[% rule.categorycode %]&branch=[% rule.current_branch %]"><i class="fa fa-trash"></i> Delete</a> >+ <a class="btn btn-mini delete" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&itemtype=[% rule.itemtype %]&categorycode=[% rule.categorycode %]&branch=[% rule.current_branch %]"><i class="fa fa-trash"></i> Delete</a> > </td> > </tr> > [% END %] >@@ -438,7 +444,7 @@ for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidde > </td> > <td class="actions"> > <button type="submit" class="btn btn-mini"><i class="fa fa-save"></i> Save</button> >- <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-cat&categorycode=*&branch=[% current_branch %]"><i class="fa fa-undo"></i> Unset</a> >+ <a class="btn btn-mini delete" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-cat&categorycode=*&branch=[% current_branch %]" id="unset"><i class="fa fa-undo"></i> Unset</a> > </td> > </tr> > </table> >@@ -489,7 +495,7 @@ for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidde > </td> > > <td class="actions"> >- <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-cat&categorycode=[% branch_cat_rule_loo.categorycode %]&branch=[% current_branch %]"><i class="fa fa-trash"></i> Delete</a> >+ <a class="btn btn-mini delete" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-cat&categorycode=[% branch_cat_rule_loo.categorycode %]&branch=[% current_branch %]"><i class="fa fa-trash"></i> Delete</a> > </td> > </tr> > [% END %] >@@ -569,7 +575,7 @@ for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidde > [% END %] > </td> > <td class="actions"> >- <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-item&itemtype=[% branch_item_rule_loo.itemtype %]&branch=[% current_branch %]"><i class="fa fa-trash"></i> Delete</a> >+ <a class="btn btn-mini delete" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-item&itemtype=[% branch_item_rule_loo.itemtype %]&branch=[% current_branch %]"><i class="fa fa-trash"></i> Delete</a> > </td> > </tr> > [% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16268
:
50253
|
50301
|
50502
|
50602
|
50670
|
50706
|
50727