Bugzilla – Attachment 50799 Details for
Bug 11565
decreaseLoanHighHolds needs Override
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11565: (QA followup) add class to allow feature to be easily hidden
PASSED-QA-Bug-11565-QA-followup-add-class-to-allow.patch (text/plain), 3.54 KB, created by
Katrin Fischer
on 2016-04-27 12:51:53 UTC
(
hide
)
Description:
[PASSED QA] Bug 11565: (QA followup) add class to allow feature to be easily hidden
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-04-27 12:51:53 UTC
Size:
3.54 KB
patch
obsolete
>From d6ecb973218049efabbe36862c4c4f5a8dd91570 Mon Sep 17 00:00:00 2001 >From: Jesse Weaver <jweaver@bywatersolutions.com> >Date: Wed, 30 Sep 2015 11:48:14 -0400 >Subject: [PATCH] [PASSED QA] Bug 11565: (QA followup) add class to allow > feature to be easily hidden > >This wraps both checkboxes (in the confirmation dialog and checkout >interface) in a class of "circ-override-high-holds" so they can be >easily hidden. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/circ/circulation.tt | 30 ++++++++++++---------- > 1 file changed, 16 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index c548863..5d203ed 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -350,7 +350,7 @@ $(document).ready(function() { > [% IF (forceallow) %]<input type="hidden" name="forceallow" value="1">[% END %] > > [% IF HIGHHOLDS %] >- <p> >+ <p class="circ-override-high-holds"> > <input type="checkbox" name="override_high_holds_tmp" id="override_high_holds_tmp" value="1" /> > <label for="override_high_holds_tmp">Don't decrease loan length based on holds</label> > </p> >@@ -665,22 +665,24 @@ No patron matched <span class="ex">[% message %]</span> > > <label for="auto_renew">Automatic renewal</label> > >- [% IF Koha.Preference('decreaseLoanHighHolds') %] >- [% IF NEEDSCONFIRMATION %] >- [% IF override_high_holds %] >- <input type="checkbox" name="override_high_holds" id="override_high_holds" value="1" disabled="disabled" checked="checked"/> >+ <span class="circ-override-high-holds"> >+ [% IF Koha.Preference('decreaseLoanHighHolds') %] >+ [% IF NEEDSCONFIRMATION %] >+ [% IF override_high_holds %] >+ <input type="checkbox" name="override_high_holds" id="override_high_holds" value="1" disabled="disabled" checked="checked"/> >+ [% ELSE %] >+ <input type="checkbox" name="override_high_holds" id="override_high_holds" value="1" disabled="disabled"/> >+ [% END %] > [% ELSE %] >- <input type="checkbox" name="override_high_holds" id="override_high_holds" value="1" disabled="disabled"/> >- [% END %] >- [% ELSE %] >- [% IF override_high_holds %] >- <input type="checkbox" name="override_high_holds" id="override_high_holds" value="1" checked="checked" /> >- [% ELSE %] >- <input type="checkbox" name="override_high_holds" id="override_high_holds" value="1" /> >+ [% IF override_high_holds %] >+ <input type="checkbox" name="override_high_holds" id="override_high_holds" value="1" checked="checked" /> >+ [% ELSE %] >+ <input type="checkbox" name="override_high_holds" id="override_high_holds" value="1" /> >+ [% END %] > [% END %] >+ <label for="override_high_holds">Don't decrease loan length based on holds</label> > [% END %] >- <label for="override_high_holds">Don't decrease loan length based on holds</label> >- [% END %] >+ </span> > </div> > [% END %] > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11565
:
42976
|
43160
|
43600
|
48679
|
49409
|
49937
|
50798
| 50799 |
50800
|
50815
|
50817
|
50818
|
50820
|
50821
|
50822
|
50828
|
50829