From e96fdb2b99ef1d326ccec66a887ed937686f2685 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 27 Apr 2016 09:37:06 -0400 Subject: [PATCH] [PASSED QA] Bug 16366 - Remove obsolete "border" attribute from tags MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch removes the obsolete "border" attribute from tags. Browsers haven't applied an border to images by default for years. There should be no visible changes as a result of this patch. It only affects HTML validation. If you want to test the affected pages, apply the patch and confirm that images look correct on these pages: - In the patron sidebar menu, if patron images are enabled. - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? - On the advanced search page, itemtype/collection/shelving location images should look correct. - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. Signed-off-by: Marc VĂ©ron Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 4 ++-- .../prog/en/modules/admin/auth_subfields_structure.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/authorities/detail.tt | 2 +- .../prog/en/modules/catalogue/MARCdetail.tt | 2 +- .../intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +- .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/reserve/request.tt | 16 ++++++++-------- .../prog/en/modules/tools/marc_modification_templates.tt | 8 ++++---- 8 files changed, 21 insertions(+), 21 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index f545afa..cc43860 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -8,9 +8,9 @@
    [% IF ( patronimages ) %] [% IF ( picture ) %] -
  • [% firstname %] [% surname %] ([% cardnumber %])
  • +
  • [% firstname %] [% surname %] ([% cardnumber %])
  • [% ELSE %] -
  • [% firstname %] [% surname %] ([% cardnumber %])
  • +
  • [% firstname %] [% surname %] ([% cardnumber %])
  • [% END %] [% END %] [% IF Koha.Preference( 'AddressFormat' ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt index 7caceca..66045a8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt @@ -321,12 +321,12 @@ [% IF ( previous ) %] - + [% END %] [% IF ( next ) %] [% next %] - + [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt index 3b7f262..295c325 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt @@ -125,7 +125,7 @@ function searchauthority() { [% subfiel.marc_value %] [% IF ( subfiel.link ) %] - + [% END %] [% IF ( subfiel.authority ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt index 4c0c115..992bd0a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt @@ -93,7 +93,7 @@ function Changefwk(FwkList) { [% IF ( subfiel.is_url ) %][% subfiel.marc_value |html %][% ELSE %][% subfiel.marc_value |html %][% END %] [% IF ( subfiel.link ) %] - Search on [% subfiel.marc_value |html %] + Search on [% subfiel.marc_value |html %] [% END %] [% IF ( subfiel.authority ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt index e2bd3cc..ebf878a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt @@ -117,7 +117,7 @@ [% FOREACH itemtypeloo IN advsearchloo.code_loop %] - [% IF ( loop.last ) %][% ELSE %][% UNLESS ( loop.count % 5 ) %][% END %][% END %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index e314fa1..24fde0c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -387,7 +387,7 @@ function verify_images() { [% IF ( AmazonCoverImages ) %] [% END %] [% END %] @@ -461,7 +461,7 @@ function verify_images() { [% IF ( AmazonCoverImages ) %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 473cfb4..7a73571 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -677,7 +677,7 @@ function checkMultiHold() { [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] - + [% END %] [% IF SuspendHoldsIntranet %][% END %] @@ -715,19 +715,19 @@ function checkMultiHold() { [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] [% END %] @@ -808,9 +808,9 @@ function checkMultiHold() { @@ -818,7 +818,7 @@ function checkMultiHold() { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt index 1086670..c7a1b2b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt @@ -79,19 +79,19 @@ -- 1.9.1
    Pickup library DetailsToggle set to lowest priorityToggle set to lowest priority   - Go up + Go up - Go top + Go top - Go bottom + Go bottom - Go down + Go down [% IF ( reserveloo.lowestPriority ) %] - Unset lowest priority + Unset lowest priority [% ELSE %] - Set to lowest priority + Set to lowest priority [% END %] - Cancel + Cancel
    - Go up + Go up - Go top + Go top - Go bottom + Go bottom - Go down + Go down