From 6d25ed4fc0cac6c54819db266aa54ad482df733a Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Wed, 6 Jul 2016 11:51:40 -0400 Subject: [PATCH] [SIGNED-OFF]Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools Signed-off-by: Hector Castro Workas as advertised --- t/db_dependent/ClassSource.t | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/ClassSource.t b/t/db_dependent/ClassSource.t index 5e8a0ec..99beb3d 100644 --- a/t/db_dependent/ClassSource.t +++ b/t/db_dependent/ClassSource.t @@ -2,7 +2,8 @@ use Modern::Perl; -use Test::More tests => 24; +use Test::More tests => 25; +use Test::Warn; use C4::Context; @@ -126,8 +127,12 @@ is_deeply( ); #Test GetClassSort -my $getclassSort = GetClassSort( 'source1', 'sortrule1', 'item1' ) - ; #Note: Create a warning:" attempting to use non-existent class sorting routine $sort_routine" +my $getclassSort; +#Note: Create a warning:" attempting to use non-existent class sorting routine $sort_routine" +warning_like + { $getclassSort = GetClassSort( 'source1', 'sortrule1', 'item1' ) } + qr/attempting to use non-existent class sorting routine/, + 'Non-existent class warning caught'; is( $getclassSort, "SORTRULE1_ITEM1", " the sort key corresponding to Source1 and sortrule1 and item1 is SORTRULE1_ITEM1" ); -- 1.7.10.4