Bugzilla – Attachment 53595 Details for
Bug 16948
'Return to batch item deletion' button should only show when there are items that could not be deleted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16948: 'Return to batch item deletion' button should only show when there are items that could not be deleted
Bug-16948-Return-to-batch-item-deletion-button-sho.patch (text/plain), 2.50 KB, created by
Jonathan Druart
on 2016-07-21 16:50:20 UTC
(
hide
)
Description:
Bug 16948: 'Return to batch item deletion' button should only show when there are items that could not be deleted
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-07-21 16:50:20 UTC
Size:
2.50 KB
patch
obsolete
>From f759c956ec517ce53e569657eb06d18c95a8f683 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Wed, 20 Jul 2016 21:57:32 +0000 >Subject: [PATCH] Bug 16948: 'Return to batch item deletion' button should only > show when there are items that could not be deleted > >To test: > >1) Go to Tools --> Batch item deletion >2) Put in an item barcode and click Continue >3) Deselect the item (so that you don't actually delete it) and click Delete selected items >4) Notice there are two links that say 'Return to batch item deletion' - one as a link and one as a button. >5) Apply patch and refresh page. You may have to go back and resend the form >6) Button should be gone, only one link shows. >7) Check out the same item that you are testing with to a patron >8) Put the barcode into batch item deletion again and follow the prompts. Do not deselect it after clicking Continue this time. (It will not be deleted as it has been checked out). >9) After clicking Delete selected items, you should be redirected and see a table with the item in it and the reason it can't be deleted. The button and the link saying 'Return to batch item deletion' should both be present. > >Sponsored-by: Catalyst IT >Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >index 8014d9e..55db372 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >@@ -186,11 +186,8 @@ $(document).ready(function(){ > [% END %] > </tbody> > </table> >- [% END %] > </div> >- [% END %] > >- <p> > [% IF src == 'CATALOGUING' # from catalogue/detail.pl > Delete items in a batch%] > <a class="btn" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]"><i class="fa fa-check-square-o"></i> Return to the record</a> > [% ELSIF src %] >@@ -198,7 +195,9 @@ $(document).ready(function(){ > [% ELSE %] > <a class="btn" href="/cgi-bin/koha/tools/batchMod.pl?del=1"><i class="fa fa-check-square-o"></i> Return to batch item deletion</a> > [% END %] >- </p> >+ [% END %] <!-- not_deleted_loop --> >+ [% END %] <!-- not_deleted_items --> >+ > [% END %] > </div> > </div> >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16948
:
53539
|
53558
| 53595