From af02c796c5793d5b3e1e3fc54d981a502d877c5e Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 26 Jul 2016 16:04:16 -0300 Subject: [PATCH] Bug 14642: (QA followup) Make HoldsLog default to 0 After a couple comments regarding the default value I picked for the new syspref, I've decided to set it 0, as libraries interested on the fetarue will just enable it. Signed-off-by: Tomas Cohen Arazi --- installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql | 4 ++-- installer/data/mysql/sysprefs.sql | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql b/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql index aca2ee3..85a08eb 100644 --- a/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql +++ b/installer/data/mysql/atomicupdate/bug_14642_holds_logging.sql @@ -1,11 +1,11 @@ INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES -('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); +('HoldsLog','0',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); -- $DBversion = "16.06.00.XXX"; -- if ( CheckVersion($DBversion) ) { -- $dbh->do(q{ -- INSERT IGNORE INTO systempreferences ( variable, value, options, explanation, type ) VALUES --- ('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); +-- ('HoldsLog','0',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'); -- }); -- print "Upgrade to $DBversion done (Bug 14642: Add logging of hold modifications)\n"; diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql index 3922b43..ffe31eb 100644 --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql @@ -168,7 +168,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('HighlightOwnItemsOnOPAC','0','','If on, and a patron is logged into the OPAC, items from his or her home library will be emphasized and shown first in search results and item details.','YesNo'), ('HighlightOwnItemsOnOPACWhich','PatronBranch','PatronBranch|OpacURLBranch','Decides which branch\'s items to emphasize. If PatronBranch, emphasize the logged in user\'s library\'s items. If OpacURLBranch, highlight the items of the Apache var BRANCHCODE defined in Koha\'s Apache configuration file.','Choice'), ('HoldFeeMode','not_always','always|not_always','Set the hold fee mode','Choice'), -('HoldsLog','1',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'), +('HoldsLog','0',NULL,'If ON, log create/cancel/suspend/resume actions on holds.','YesNo'), ('HoldsQueueSkipClosed', '0', NULL, 'If enabled, any libraries that are closed when the holds queue is built will be ignored for the purpose of filling holds.', 'YesNo'), ('HoldsToPullStartDate','2',NULL,'Set the default start date for the Holds to pull list to this many days ago','Integer'), ('HomeOrHoldingBranch','holdingbranch','holdingbranch|homebranch','Used by Circulation to determine which branch of an item to check with independent branches on, and by search to determine which branch to choose for availability ','Choice'), -- 2.7.4