Bugzilla – Attachment 53736 Details for
Bug 15023
Allow patron anonymize/bulk delete tool to be limited by branch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15023: (followup) Remove warnings
PASSED-QA-Bug-15023-followup-Remove-warnings.patch (text/plain), 1.05 KB, created by
Katrin Fischer
on 2016-07-26 19:45:05 UTC
(
hide
)
Description:
[PASSED QA] Bug 15023: (followup) Remove warnings
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-07-26 19:45:05 UTC
Size:
1.05 KB
patch
obsolete
>From 70f708388491736a01114cecfdf71ce5bc24e0a7 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 27 Jun 2016 12:24:15 -0300 >Subject: [PATCH] [PASSED QA] Bug 15023: (followup) Remove warnings > >By setting 'use Modern::Perl' some previously hidden warnings arised. >This patch removes them by testing the variable $balance for undef >before using it in a comparisson. > >Sponsored-by: VOKAL >Signed-off-by: Liz Rea <liz@catalyst.net.nz> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > tools/cleanborrowers.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/cleanborrowers.pl b/tools/cleanborrowers.pl >index df2196f..4cc9169 100755 >--- a/tools/cleanborrowers.pl >+++ b/tools/cleanborrowers.pl >@@ -188,7 +188,7 @@ sub _skip_borrowers_with_nonzero_balance { > my $balance; > @$borrowers = map { > (undef, undef, $balance) = GetMemberIssuesAndFines( $_->{borrowernumber} ); >- ($balance != 0) ? (): ($_); >+ (defined $balance && $balance != 0) ? (): ($_); > } @$borrowers; > } > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15023
:
52899
|
52900
|
53463
|
53464
|
53735
| 53736