Bugzilla – Attachment 54183 Details for
Bug 14642
Add logging of hold modifications
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14642: Make sure the log will be written only if the hold has been deleted
Bug-14642-Make-sure-the-log-will-be-written-only-i.patch (text/plain), 891 bytes, created by
Jonathan Druart
on 2016-08-09 09:16:00 UTC
(
hide
)
Description:
Bug 14642: Make sure the log will be written only if the hold has been deleted
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-08-09 09:16:00 UTC
Size:
891 bytes
patch
obsolete
>From a9e94a654312a105f93862fa914f317f108321bc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 9 Aug 2016 10:14:44 +0100 >Subject: [PATCH] Bug 14642: Make sure the log will be written only if the hold > has been deleted > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > Koha/Hold.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index 3cc8440..ba75a52 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -99,10 +99,12 @@ $hold->delete(); > sub delete { > my ( $self ) = @_; > >+ my $deleted = $self->SUPER::delete($self); >+ > logaction( 'HOLDS', 'DELETE', $self->reserve_id, Dumper($self->unblessed) ) > if C4::Context->preference('HoldsLog'); > >- return $self->SUPER::delete($self); >+ return $deleted; > } > > =head3 waiting_expires_on >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14642
:
52824
|
52825
|
52848
|
52931
|
53070
|
53196
|
53466
|
53734
|
54177
|
54179
|
54180
|
54181
|
54182
| 54183