Bugzilla – Attachment 5524 Details for
Bug 6824
Basket permissions not looked up correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6824 - signed off patch: correctly check basket viewing permissions
0001-Signed-off.patch (text/plain), 1.95 KB, created by
Melia Meggs
on 2011-09-21 21:12:12 UTC
(
hide
)
Description:
Bug 6824 - signed off patch: correctly check basket viewing permissions
Filename:
MIME Type:
Creator:
Melia Meggs
Created:
2011-09-21 21:12:12 UTC
Size:
1.95 KB
patch
obsolete
>From 46f56168bb6dae7c81ccf6fa25b8ad4ef8a1831f Mon Sep 17 00:00:00 2001 >From: Robin Sheat <robin@catalyst.net.nz> >Date: Wed, 31 Aug 2011 15:22:38 +1200 >Subject: [PATCH] (Signed-off) > signed of by Melia Meggs > >Bug 6824 - correctly check basket viewing permissions > >Previously you couldn't view baskets that you hadn't created, unless you >were superlibrarian due to a bug. Now people with the right permissions >can see the baskets. > >Applies to both 3.04.04 and master. > >Signed-off-by: Brendan <info@bywatersolutions.com> >--- > acqui/basket.pl | 2 +- > acqui/booksellers.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/acqui/basket.pl b/acqui/basket.pl >index dfc9447..70fb39c 100755 >--- a/acqui/basket.pl >+++ b/acqui/basket.pl >@@ -197,7 +197,7 @@ if ( $op eq 'delete_confirm' ) { > #if the basket is closed,and the user has the permission to edit basketgroups, display a list of basketgroups > my $basketgroups; > my $member = GetMember(borrowernumber => $loggedinuser); >- if ($basket->{closedate} && haspermission({ flagsrequired => { acquisition => 'group_manage'} })) { >+ if ($basket->{closedate} && haspermission({ acquisition => 'group_manage'} )) { > $basketgroups = GetBasketgroups($basket->{booksellerid}); > for my $bg ( @{$basketgroups} ) { > if ($basket->{basketgroupid} && $basket->{basketgroupid} == $bg->{id}){ >diff --git a/acqui/booksellers.pl b/acqui/booksellers.pl >index cc5c084..fb6b2f1 100755 >--- a/acqui/booksellers.pl >+++ b/acqui/booksellers.pl >@@ -106,7 +106,7 @@ for my $vendor (@suppliers) { > if (( $basket->{authorisedby} > && $basket->{authorisedby} eq $loggedinuser > ) >- || haspermission( $uid, { flagsrequired => { acquisition => q{*} } } ) >+ || haspermission( $uid, { acquisition => q{*} } ) > ) { > for my $date_field (qw( creationdate closedate)) { > if ( $basket->{$date_field} ) { >-- >1.7.2.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6824
:
5234
| 5524