Bugzilla – Attachment 56475 Details for
Bug 17173
Quick edit a subfield in frameworks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17173: Quick jump to subfield edition form
Bug-17173-Quick-jump-to-subfield-edition-form.patch (text/plain), 1.85 KB, created by
Nick Clemens (kidclamp)
on 2016-10-14 08:18:39 UTC
(
hide
)
Description:
Bug 17173: Quick jump to subfield edition form
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2016-10-14 08:18:39 UTC
Size:
1.85 KB
patch
obsolete
>From 0cc51339d063dd68ed28e3d00ce4a97b9b1bd5f6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 23 Aug 2016 18:50:20 +0100 >Subject: [PATCH] Bug 17173: Quick jump to subfield edition form >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >There are too many clicks to jump to the edit form of a specific >subfield. > >This patch adds a hidden feature (i.e. will not be polished or >documented). > >When searching for a tag field from a marc framework structure, it's not >possible to search for a tag subfield to jump directly to the subfield >edition form. > >Test plan: >On /admin/marctagstructure.pl?frameworkcode=FRAMEWORKCODE >Search for a subfield (952$d) >you will be redirected to the subfield edition form > >There is no check if the subfield does not exist. > >Followed test plan, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > admin/marctagstructure.pl | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/admin/marctagstructure.pl b/admin/marctagstructure.pl >index 784fb50..3d5c6e4 100755 >--- a/admin/marctagstructure.pl >+++ b/admin/marctagstructure.pl >@@ -285,6 +285,12 @@ if ($op eq 'add_form') { > $template->param(select_display => "True", > loop => \@loop_data); > } else { >+ # Hidden feature: If search was field$subfield, redirect to the subfield edit form >+ my ( $tagfield, $tagsubfield ) = split /\$/, $searchfield; >+ if ( $tagsubfield ) { >+ print $input->redirect('/cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield='.$tagfield.'&frameworkcode='.$frameworkcode.'#sub'.$tagsubfield.'field'); >+ exit; >+ } > #here, normal old style : display every tags > my ($count,$results)=StringSearch($searchfield,$frameworkcode); > $cnt = $count; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17173
:
54786
|
54829
| 56475