Bugzilla – Attachment 5749 Details for
Bug 6983
Item type filter on overdues report does not respect item-level_itypes preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-6983-Item-type-filter-on-overdues-report.patch (text/plain), 1.63 KB, created by
Owen Leonard
on 2011-10-06 19:18:38 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-10-06 19:18:38 UTC
Size:
1.63 KB
patch
obsolete
>From c7ffd164944d66db5517ff3fc97b06a5751189b5 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 6 Oct 2011 15:13:30 -0400 >Subject: [PATCH] Fix for Bug 6983 - Item type filter on overdues report does not respect item-level_itypes >Content-Type: text/plain; charset="utf-8" > >This patch adds a check for the item-level_itypes preference >when building the SQL for the overdues report. >--- > circ/overdue.pl | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > >diff --git a/circ/overdue.pl b/circ/overdue.pl >index 2bdafe1..7467874 100755 >--- a/circ/overdue.pl >+++ b/circ/overdue.pl >@@ -265,7 +265,13 @@ if ($noreport) { > $strsth.=" AND date_due < '" . $todaysdate . "' " unless ($showall); > $strsth.=" AND (borrowers.firstname like '".$bornamefilter."%' or borrowers.surname like '".$bornamefilter."%' or borrowers.cardnumber like '".$bornamefilter."%')" if($bornamefilter) ; > $strsth.=" AND borrowers.categorycode = '" . $borcatfilter . "' " if $borcatfilter; >- $strsth.=" AND biblioitems.itemtype = '" . $itemtypefilter . "' " if $itemtypefilter; >+ if( $itemtypefilter ){ >+ if( C4::Context->preference('item-level_itypes') ){ >+ $strsth.=" AND items.itype = '" . $itemtypefilter . "' "; >+ } else { >+ $strsth.=" AND biblioitems.itemtype = '" . $itemtypefilter . "' "; >+ } >+ } > $strsth.=" AND borrowers.flags = '" . $borflagsfilter . "' " if $borflagsfilter; > $strsth.=" AND borrowers.branchcode = '" . $branchfilter . "' " if $branchfilter; > $strsth.=" AND date_due < '" . $datedueto . "' " if $datedueto; >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6983
: 5749