Bugzilla – Attachment 58575 Details for
Bug 17836
(ILSDI) 'charges' always '1'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly
Bug-17836-ILSDI-Make-GetPatronInfo-fill-charges-co.patch (text/plain), 1.41 KB, created by
Mark Tompsett
on 2017-01-03 17:37:02 UTC
(
hide
)
Description:
Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-01-03 17:37:02 UTC
Size:
1.41 KB
patch
obsolete
>From efd172589f90218230a49276fe343f89c7039fc5 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 3 Jan 2017 13:14:25 -0300 >Subject: [PATCH] Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' > correctly > >This trivial fix corrects a typo on C4/ILSDI/Services.pm. >It was hidden because the tests for ILSDI only cover the 'attributes' >portion of the response. I added regression tests for this. > >To test: >- Have the regression test patch applied >- Run: > $ prove t/db_dependent/ILSDI_Services.t >=> FAIL: Tests fail because 'charges' is always set to 1 >- Apply the patch >- Run: > $ prove t/db_dependent/ILSDI_Services.t >=> SUCCESS: Tests pass >- Sign off :-D > >Sponsored-by: ByWater Solutions > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > C4/ILSDI/Services.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm >index 23ec85a..26786a0 100644 >--- a/C4/ILSDI/Services.pm >+++ b/C4/ILSDI/Services.pm >@@ -376,7 +376,7 @@ sub GetPatronInfo { > > # Cleaning the borrower hashref > my $flags = C4::Members::patronflags( $borrower ); >- $borrower->{'charges'} = $flags>{'CHARGES'}->{'amount'}; >+ $borrower->{'charges'} = $flags->{'CHARGES'}->{'amount'}; > my $library = Koha::Libraries->find( $borrower->{branchcode} ); > $borrower->{'branchname'} = $library ? $library->branchname : ''; > delete $borrower->{'userid'}; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17836
:
58568
|
58569
|
58574
|
58575
|
58981
|
58982