Bugzilla – Attachment 59513 Details for
Bug 17780
When choose an author in authority results new window shows a blank screen
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17780: JS structure check fix
0001-Bug-17780-When-choose-an-author-in-authority-results.patch (text/plain), 1.59 KB, created by
Oleg Vasylenko
on 2017-01-24 16:11:52 UTC
(
hide
)
Description:
Bug 17780: JS structure check fix
Filename:
MIME Type:
Creator:
Oleg Vasylenko
Created:
2017-01-24 16:11:52 UTC
Size:
1.59 KB
patch
obsolete
>From 941e6b2907c5593f4faeb150de1b3ba921fc8613 Mon Sep 17 00:00:00 2001 >From: Oleg Vasylenko <synapse.ova@gmail.com> >Date: Tue, 24 Jan 2017 17:58:39 +0200 >Subject: [PATCH 2/2] Bug 17780 - When choose an author in authority results > new window shows a blank screen > >Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. >This patch checks if input has name attribute, because some inputs in Select2 have not. > >To test: >Try to add info from the authorities to field that has subfield with Select2 (subfield with authorised values on Koha 16.11+) >--- > .../prog/en/modules/authorities/blinddetail-biblio-search.tt | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt >index c95a29b0d9..da9ac248e2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt >@@ -90,6 +90,7 @@ > var subfields = field_start.getElementsByTagName('input'); > var re = /^tag_\d*_code_/; > for(var i=0, len = subfields.length ; i< len ; i++) { // browse all subfields >+ if(subfields[i].hasAttribute('name') == 0 ) {continue; } > if(subfields[i].getAttribute('name').match(re)){ // it s a subfield > var code = subfields[i]; // code is the first input > var subfield = subfields[i+1]; // subfield the second >-- >2.11.0.windows.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17780
:
58199
|
59513
|
60238
|
60241
|
60242