From b4d32de12a56b721787ce87fbb4dccdacdcef7e1 Mon Sep 17 00:00:00 2001 From: Ian Walls Date: Tue, 18 Oct 2011 18:31:00 -0400 Subject: [PATCH] [SIGNED-OFF] Bug 7059: Remove GetMemberDetails from reserve/request.pl Replaces all four usages of GetMemberDetails with GetMember, since none of the hashref fields used were anything other than those in borrower table, which GetMember returns. To Test: 1. Apply patch 2. Go to reserve/request.pl; the page should load without error 3. Search for a cardnumber: the page should load without error Signed-off-by: Nicole C. Engard --- reserve/request.pl | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/reserve/request.pl b/reserve/request.pl index cfeea73..21183da 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -129,7 +129,7 @@ if ($findborrower) { # If we have the borrowernumber because we've performed an action, then we # don't want to try to place another reserve. if ($borrowernumber_hold && !$action) { - my $borrowerinfo = GetMemberDetails( $borrowernumber_hold ); + my $borrowerinfo = GetMember( borrowernumber => $borrowernumber_hold ); my $diffbranch; my @getreservloop; my $count_reserv = 0; @@ -217,8 +217,8 @@ if ($borrowerslist) { ); } -# FIXME launch another time GetMemberDetails perhaps until -my $borrowerinfo = GetMemberDetails( $borrowernumber_hold ); +# FIXME launch another time GetMember perhaps until +my $borrowerinfo = GetMember( borrowernumber => $borrowernumber_hold ); my @biblionumbers = (); my $biblionumbers = $input->param('biblionumbers'); @@ -373,7 +373,7 @@ foreach my $biblionumber (@biblionumbers) { # checking reserve my ($reservedate,$reservedfor,$expectedAt) = GetReservesFromItemnumber($itemnumber); - my $ItemBorrowerReserveInfo = GetMemberDetails( $reservedfor, 0); + my $ItemBorrowerReserveInfo = GetMember( borrowernumber => $reservedfor ); if ( defined $reservedate ) { $item->{backgroundcolor} = 'reserved'; @@ -542,7 +542,7 @@ foreach my $biblionumber (@biblionumbers) { } # get borrowers reserve info - my $reserveborrowerinfo = GetMemberDetails( $res->{'borrowernumber'}, 0); + my $reserveborrowerinfo = GetMember( borrowernumber => $res->{'borrowernumber'} ); if (C4::Context->preference('HidePatronName')){ $reserve{'hidename'} = 1; $reserve{'cardnumber'} = $reserveborrowerinfo->{'cardnumber'}; -- 1.7.2.3