Bugzilla – Attachment 5997 Details for
Bug 7061
SQLHelper has unused global variables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 7061: unnecessary global variables declared in C4::SQLHelper
SIGNED-OFF-Bug-7061-unnecessary-global-variables-d.patch (text/plain), 1.13 KB, created by
Nicole C. Engard
on 2011-10-19 19:56:14 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 7061: unnecessary global variables declared in C4::SQLHelper
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2011-10-19 19:56:14 UTC
Size:
1.13 KB
patch
obsolete
>From 9b2c0e898151e3eea10a4b8c3bceacfab0188e33 Mon Sep 17 00:00:00 2001 >From: Ian Walls <ian.walls@bywatersolutions.com> >Date: Tue, 18 Oct 2011 20:17:17 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 7061: unnecessary global variables declared in C4::SQLHelper > >Removes $tablename and $hash from global scope of C4/SQLHelper.pm. They are never used; >all instances of $table are locally scoped to the subroutines, and $hash is never used. > >This may help with persistance; if not, it's at least a bit of trivial cleanup. > >To test: > >1. Search for a patron >2. Create a Contract in Acquisitions >3. Modify that Contract >4. Delete that Contract > >All instances should return error free. This checks the subroutines of SQLHelper > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >--- > C4/SQLHelper.pm | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > >diff --git a/C4/SQLHelper.pm b/C4/SQLHelper.pm >index 720dc99..e5ca94e 100644 >--- a/C4/SQLHelper.pm >+++ b/C4/SQLHelper.pm >@@ -43,9 +43,6 @@ BEGIN { > ); > } > >-my $tablename; >-my $hash; >- > =head1 NAME > > C4::SQLHelper - Perl Module containing convenience functions for SQL Handling >-- >1.7.2.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7061
:
5970
| 5997