From c8dae9bdae5a5b90df79f855da530323cd96de4c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 6 Jan 2017 13:36:35 +0100 Subject: [PATCH] Bug 17736: [QA Follow-up] Script basket.pl is not Plack compliant Several warnings like: Variable "$confirm_pref" is not available at /usr/share/koha/masterclone/acqui/basket.pl line 507. Primarily caused by sub edi_close_and_order. Easy fix. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize --- acqui/basket.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/acqui/basket.pl b/acqui/basket.pl index db99c6b..4b39f00 100755 --- a/acqui/basket.pl +++ b/acqui/basket.pl @@ -69,13 +69,13 @@ the supplier this script have to display the basket. =cut -my $query = new CGI; +our $query = new CGI; our $basketno = $query->param('basketno'); -my $ean = $query->param('ean'); -my $booksellerid = $query->param('booksellerid'); +our $ean = $query->param('ean'); +our $booksellerid = $query->param('booksellerid'); my $duplinbatch = $query->param('duplinbatch'); -my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user( +our ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user( { template_name => "acqui/basket.tt", query => $query, @@ -86,7 +86,7 @@ my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user( } ); -my $basket = GetBasket($basketno); +our $basket = GetBasket($basketno); $booksellerid = $basket->{booksellerid} unless $booksellerid; my $bookseller = Koha::Acquisition::Booksellers->find( $booksellerid ); my $schema = Koha::Database->new()->schema(); @@ -112,7 +112,7 @@ unless (CanUserManageBasket($loggedinuser, $basket, $userflags)) { # warn "=>".$basket->{booksellerid}; my $op = $query->param('op') // 'list'; -my $confirm_pref= C4::Context->preference("BasketConfirmations") || '1'; +our $confirm_pref= C4::Context->preference("BasketConfirmations") || '1'; $template->param( skip_confirm_reopen => 1) if $confirm_pref eq '2'; my @messages; -- 2.1.4