From 27df75e133f3acf881b08a890db893e5f6f4c4ea Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 21 Mar 2017 12:24:28 -0300 Subject: [PATCH] Bug 18266: Fix internal error when paying fine for lost item without.. item If a fine is created for a lost item but the itemnumber is not supplied, the system will return it. The item should not be mark as returned if there is no item linked to the fine. Test plan: 1. Turn StoreLastBorrower on 2. Create a manual invoice for a lost item, do not supply a barcode 3. Pay the fines 'Pay fines > Pay' => Without this patch applied you get Can't call method "last_returned_by" on an undefined value at /home/marc/koha/C4/Circulation.pm line 2188. => With this patch applied, you must not get the error. --- C4/Accounts.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Accounts.pm b/C4/Accounts.pm index e49becb..bba267c 100644 --- a/C4/Accounts.pm +++ b/C4/Accounts.pm @@ -169,7 +169,7 @@ sub makepayment { }); #check to see what accounttype - if ( $data->{'accounttype'} eq 'Rep' || $data->{'accounttype'} eq 'L' ) { + if ( $data->{itemnumber} && ( $data->{'accounttype'} eq 'Rep' || $data->{'accounttype'} eq 'L' ) ) { C4::Circulation::ReturnLostItem( $borrowernumber, $data->{'itemnumber'} ); } my $sthr = $dbh->prepare("SELECT max(accountlines_id) AS lastinsertid FROM accountlines"); -- 2.9.3