Bugzilla – Attachment 61908 Details for
Bug 18349
Possibility to checkout/renew bypassing the circ rules using SCO
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18349: SCO - Do not trust the confirmed flag
Bug-18349-SCO---Do-not-trust-the-confirmed-flag.patch (text/plain), 1.72 KB, created by
Nick Clemens (kidclamp)
on 2017-04-05 16:43:17 UTC
(
hide
)
Description:
Bug 18349: SCO - Do not trust the confirmed flag
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-04-05 16:43:17 UTC
Size:
1.72 KB
patch
obsolete
>From 8c03ce87a860a4026c3e0aa4d0ee71ba9341d520 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 29 Mar 2017 18:25:40 -0300 >Subject: [PATCH] Bug 18349: SCO - Do not trust the confirmed flag > >The "confirmed" flag is used to know if that user confirmed a situation >that needs a confirmation. >But if the issue/renew is impossible the CanBookBeIssued and the >'impossible flags' should be checked. > >Otherwise a patron can checkout and renew bypassing the circulation >rules (Understand 'no limit' here...) > >Test plan: >Want to renew? >Checkin $barcode, then >/cgi-bin/koha/sco/sco-main.pl?patronid=$cardnumber&barcode=$barcode&confirmed=1&op=checkout > >Want to bypass the checkin? >Same url... > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > opac/sco/sco-main.pl | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > >diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl >index b313df9..0486dd4 100755 >--- a/opac/sco/sco-main.pl >+++ b/opac/sco/sco-main.pl >@@ -137,15 +137,13 @@ elsif ( $op eq "returnbook" && $allowselfcheckreturns ) { > elsif ( $op eq "checkout" ) { > my $impossible = {}; > my $needconfirm = {}; >- if ( !$confirmed ) { >- ( $impossible, $needconfirm ) = CanBookBeIssued( >- $borrower, >- $barcode, >- undef, >- 0, >- C4::Context->preference("AllowItemsOnHoldCheckoutSCO") >- ); >- } >+ ( $impossible, $needconfirm ) = CanBookBeIssued( >+ $borrower, >+ $barcode, >+ undef, >+ 0, >+ C4::Context->preference("AllowItemsOnHoldCheckoutSCO") >+ ); > $confirm_required = scalar keys %$needconfirm; > > #warn "confirm_required: " . $confirm_required ; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18349
:
61719
|
61720
|
61755
|
61756
|
61757
| 61908 |
61909
|
61910
|
61911
|
61959